Bug 226073

Summary: Compile error when ANGLE is used on Linux
Product: WebKit Reporter: Eleni Maria Stea <estea>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, bugs-noreply, estea, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Linux   
Attachments:
Description Flags
Patch none

Eleni Maria Stea
Reported 2021-05-21 03:17:17 PDT
In platform/graphics/nicosia/texmap/NicosiaGCGLLayer.cpp: Function paintRenderingResultsToCanvas expects a reference, but a pointer is passed instead causing compile errors when ANGLE is used.
Attachments
Patch (1.94 KB, patch)
2021-05-21 03:27 PDT, Eleni Maria Stea 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eleni Maria Stea
Comment 1 2021-05-21 03:27:24 PDT
Created attachment 429279 [details] Patch
EWS
Comment 2 2021-05-21 07:54:42 PDT
Committed r277861 (238003@main): <https://commits.webkit.org/238003@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429279 [details].
Radar WebKit Bug Importer
Comment 3 2021-05-21 07:55:17 PDT
<rdar://problem/78310259>
Michael Catanzaro
Comment 4 2021-05-21 07:58:18 PDT
Comment on attachment 429279 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429279&action=review > Source/WebCore/ChangeLog:4 > + Function paintRenderingResultsToCanvas expects a reference, not a > + pointer. Fixed the compile error. In the future: the first line of the changelog is normally the bug title. You can write your commit message underneath the reviewed by line, below.
Note You need to log in before you can comment on or make changes to this bug.