| Summary: | Putting HashMap in a heap block hurts memory use, speed, code size | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||
| Component: | WebKit Misc. | Assignee: | Darin Adler <darin> | ||||||
| Status: | ASSIGNED --- | ||||||||
| Severity: | Normal | CC: | alecflett, andersca, beidson, benjamin, cdumez, cgarcia, changseok, cmarcelo, dino, esprehn+autocc, ews-watchlist, fred.wang, ggaren, glenn, graouts, gyuyoung.kim, hi, jamesr, japhet, jfernandez, joepeck, jsbell, kangil.han, keith_miller, kondapallykalyan, luiz, macpherson, mark.lam, menard, mifenton, msaboff, pdr, rego, saam, sam, simon.fraser, svillar, tonikitoo, tzagallo, webkit-bug-importer | ||||||
| Priority: | P3 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=225840 | ||||||||
| Bug Depends on: | 226162 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Darin Adler
2021-05-20 23:10:43 PDT
Created attachment 429326 [details]
Patch
*** Bug 225984 has been marked as a duplicate of this bug. *** Created attachment 429403 [details]
Patch
It’s possible that none of the memory savings here are enough to make a noticeable difference, but also possible that one of these might be common enough that we hit the jackpot. Might be less memory use or heap fragmentation. After studying test failures, I found one case that will be hard to do. I think I will make a first patch that does most of these in a separate bug and then come back to this bug later to finish the job. |