Bug 226068

Summary: Putting HashMap in a heap block hurts memory use, speed, code size
Product: WebKit Reporter: Darin Adler <darin>
Component: WebKit Misc.Assignee: Darin Adler <darin>
Status: ASSIGNED    
Severity: Normal CC: alecflett, andersca, beidson, benjamin, cdumez, cgarcia, changseok, cmarcelo, dino, esprehn+autocc, ews-watchlist, fred.wang, ggaren, glenn, graouts, gyuyoung.kim, hi, jamesr, japhet, jfernandez, joepeck, jsbell, kangil.han, keith_miller, kondapallykalyan, luiz, macpherson, mark.lam, menard, mifenton, msaboff, pdr, rego, saam, sam, simon.fraser, svillar, tonikitoo, tzagallo, webkit-bug-importer
Priority: P3 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=225840
Bug Depends on: 226162    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch ews-feeder: commit-queue-

Darin Adler
Reported 2021-05-20 23:10:43 PDT
Putting HashMap in a heap block hurts memory use, speed, code size
Attachments
Patch (275.27 KB, patch)
2021-05-21 12:51 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (281.80 KB, patch)
2021-05-21 22:14 PDT, Darin Adler 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2021-05-21 12:51:13 PDT Comment hidden (obsolete)
Radar WebKit Bug Importer
Comment 2 2021-05-21 12:52:17 PDT
<rdar://problem/78323737>
Darin Adler
Comment 3 2021-05-21 16:22:32 PDT
*** Bug 225984 has been marked as a duplicate of this bug. ***
Darin Adler
Comment 4 2021-05-21 22:14:03 PDT Comment hidden (obsolete)
Darin Adler
Comment 5 2021-05-21 22:15:58 PDT
It’s possible that none of the memory savings here are enough to make a noticeable difference, but also possible that one of these might be common enough that we hit the jackpot. Might be less memory use or heap fragmentation.
Darin Adler
Comment 6 2021-05-23 22:24:46 PDT
After studying test failures, I found one case that will be hard to do. I think I will make a first patch that does most of these in a separate bug and then come back to this bug later to finish the job.
Note You need to log in before you can comment on or make changes to this bug.