Bug 226063

Summary: [LFC][TFC][Quirks] Use box-sizing: border-box when computing cell height
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description zalan 2021-05-20 19:05:12 PDT
ssia
Comment 1 zalan 2021-05-20 19:31:14 PDT
Created attachment 429257 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-05-20 20:00:52 PDT
Comment on attachment 429257 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429257&action=review

> Source/WebCore/layout/formattingContexts/table/TableFormattingContext.cpp:307
> +        auto heightIsBorderBox = layoutState().inQuirksMode() || cellBox.style().boxSizing() == BoxSizing::BorderBox;

heightUsesBorderBox?
Comment 3 zalan 2021-05-20 20:46:37 PDT
Created attachment 429263 [details]
Patch
Comment 4 EWS 2021-05-21 06:11:17 PDT
Committed r277856 (237998@main): <https://commits.webkit.org/237998@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429263 [details].
Comment 5 Radar WebKit Bug Importer 2021-05-21 06:12:17 PDT
<rdar://problem/78307491>