| Summary: | [iOS][FCR] <select> options are unnecessarily truncated | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aditya Keerthi <akeerthi> | ||||
| Component: | Forms | Assignee: | Aditya Keerthi <akeerthi> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, thorton, webkit-bug-importer, wenson_hsieh | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | iPhone / iPad | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Aditya Keerthi
2021-05-20 15:47:47 PDT
Created attachment 429234 [details]
Patch
Comment on attachment 429234 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429234&action=review > Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm:477 > +#define UIMenuOptionsPrivateRemoveLineLimitForChildren (1 << 6) I think you want a WK prefix here? Or maybe it's OK and the compiler won't whine if it has the real one because it's a #define? Also, does UIKit ignore the random flag bit if it /doesn't/ have this change? (In reply to Tim Horton from comment #3) > Comment on attachment 429234 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=429234&action=review > > > Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm:477 > > +#define UIMenuOptionsPrivateRemoveLineLimitForChildren (1 << 6) > > I think you want a WK prefix here? Or maybe it's OK and the compiler won't > whine if it has the real one because it's a #define? Yeah, it's fine because it's a #define. (Wenson suggested this approach) > Also, does UIKit ignore the random flag bit if it /doesn't/ have this change? It's ignored. I verified the change has no effect if the corresponding UIKit change is not present. Committed r277846 (237988@main): <https://commits.webkit.org/237988@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429234 [details]. |