Bug 226042

Summary:

Video player enters a bad state after trying to enter picture-in-picture on YouTube.com videos

Product:

WebKit

Reporter:

Peng Liu <peng.liu6>

Component:

Media

Assignee:

Peng Liu <peng.liu6>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dbates, eric.carlson, jer.noble, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Peng Liu 2021-05-20 14:23:30 PDT

Video player enters a bad state after trying to enter picture-in-picture on YouTube.com videos

Comment 1 Peng Liu 2021-05-20 14:27:54 PDT

<rdar://76733650>

Comment 2 Peng Liu 2021-05-20 14:28:16 PDT

Created attachment 429222 [details]
Patch

Comment 3 Daniel Bates 2021-05-21 10:52:21 PDT

Comment on attachment 429222 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429222&action=review

> Source/WebCore/ChangeLog:9
> +        always true. This patch fixes that.

Consider explaining about std::optional

Comment 4 EWS 2021-05-21 14:12:29 PDT

Committed r277886 (238023@main): <https://commits.webkit.org/238023@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429222 [details].