Bug 226040

Summary:

Replace more static Locks with CheckedLocks in WTF / WebCore

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebCore Misc.

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, achristensen, alecflett, apinheiro, beidson, benjamin, cfleizach, changseok, cmarcelo, darin, ddkilzer, dino, dmazzoni, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, graouts, gyuyoung.kim, hi, hta, jcraig, jdiggs, jer.noble, jiewen_tan, joepeck, jsbell, kangil.han, kkinnunen, kondapallykalyan, mkwst, mmaxfield, philipj, samuel_white, sam, sergio, simon.fraser, tommyw, toyoshim, webkit-bug-importer, yutak

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=226059
https://bugs.webkit.org/show_bug.cgi?id=226060
https://bugs.webkit.org/show_bug.cgi?id=226062
https://bugs.webkit.org/show_bug.cgi?id=226092
https://bugs.webkit.org/show_bug.cgi?id=226093

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none

Chris Dumez

Reported 2021-05-20 12:55:35 PDT

Replace more static Locks with CheckedLocks so that we can benefit from Clang Thread Safety Analysis.

Attachments
Patch (132.39 KB, patch) 2021-05-20 14:00 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (130.29 KB, patch) 2021-05-20 17:40 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (126.99 KB, patch) 2021-05-20 18:20 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (124.35 KB, patch) 2021-05-20 18:29 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (96.86 KB, patch) 2021-05-21 10:21 PDT, Chris Dumez	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (110.80 KB, patch) 2021-05-21 10:51 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2021-05-20 14:00:47 PDT

Created attachment 429218 [details] Patch

Darin Adler

Comment 2 2021-05-20 17:05:12 PDT

Comment on attachment 429218 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429218&action=review Not enough time to review it all right now, but one comment. > Source/WTF/wtf/Language.cpp:98 > - preferredLanguagesOverride() = override; > + { > + Locker locker { preferredLanguagesOverrideLock }; > + preferredLanguagesOverride() = override; > + } Is this fixing a bug? Have you been mixing in fixes with the "refactor to use the checker" patches before this?

Chris Dumez

Comment 3 2021-05-20 17:09:54 PDT

Comment on attachment 429218 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429218&action=review >> Source/WTF/wtf/Language.cpp:98 >> + } > > Is this fixing a bug? Have you been mixing in fixes with the "refactor to use the checker" patches before this? Yes, it is fixing a bug that was found by clang thanks to adopting CheckedLock. Yes, the CheckedLock patches I have landed include some fixes but not many. Mostly our code was correct (Thankfully).

Chris Dumez

Comment 4 2021-05-20 17:35:18 PDT

(In reply to Chris Dumez from comment #3) > Comment on attachment 429218 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=429218&action=review > > >> Source/WTF/wtf/Language.cpp:98 > >> + } > > > > Is this fixing a bug? Have you been mixing in fixes with the "refactor to use the checker" patches before this? > > Yes, it is fixing a bug that was found by clang thanks to adopting > CheckedLock. Yes, the CheckedLock patches I have landed include some fixes > but not many. Mostly our code was correct (Thankfully). I have split this fix to Bug 226059 to make it more obvious.

Chris Dumez

Comment 5 2021-05-20 17:40:21 PDT

Created attachment 429249 [details] Patch

Chris Dumez

Comment 6 2021-05-20 18:20:45 PDT

Created attachment 429254 [details] Patch

Chris Dumez

Comment 7 2021-05-20 18:29:34 PDT

Created attachment 429256 [details] Patch

Chris Dumez

Comment 8 2021-05-20 18:32:25 PDT

Ok, I believe I have extracted all non-trivial bug fixes out into their own patches (see related bugs).