Summary: | Replace more static Locks with CheckedLocks in WTF / WebCore | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||||
Component: | WebCore Misc. | Assignee: | Chris Dumez <cdumez> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | aboxhall, achristensen, alecflett, apinheiro, beidson, benjamin, cfleizach, changseok, cmarcelo, darin, ddkilzer, dino, dmazzoni, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, graouts, gyuyoung.kim, hi, hta, jcraig, jdiggs, jer.noble, jiewen_tan, joepeck, jsbell, kangil.han, kkinnunen, kondapallykalyan, mkwst, mmaxfield, philipj, samuel_white, sam, sergio, simon.fraser, tommyw, toyoshim, webkit-bug-importer, yutak | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=226059 https://bugs.webkit.org/show_bug.cgi?id=226060 https://bugs.webkit.org/show_bug.cgi?id=226062 https://bugs.webkit.org/show_bug.cgi?id=226092 https://bugs.webkit.org/show_bug.cgi?id=226093 |
||||||||||||||||
Attachments: |
|
Description
Chris Dumez
2021-05-20 12:55:35 PDT
Created attachment 429218 [details]
Patch
Comment on attachment 429218 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429218&action=review Not enough time to review it all right now, but one comment. > Source/WTF/wtf/Language.cpp:98 > - preferredLanguagesOverride() = override; > + { > + Locker locker { preferredLanguagesOverrideLock }; > + preferredLanguagesOverride() = override; > + } Is this fixing a bug? Have you been mixing in fixes with the "refactor to use the checker" patches before this? Comment on attachment 429218 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429218&action=review >> Source/WTF/wtf/Language.cpp:98 >> + } > > Is this fixing a bug? Have you been mixing in fixes with the "refactor to use the checker" patches before this? Yes, it is fixing a bug that was found by clang thanks to adopting CheckedLock. Yes, the CheckedLock patches I have landed include some fixes but not many. Mostly our code was correct (Thankfully). (In reply to Chris Dumez from comment #3) > Comment on attachment 429218 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=429218&action=review > > >> Source/WTF/wtf/Language.cpp:98 > >> + } > > > > Is this fixing a bug? Have you been mixing in fixes with the "refactor to use the checker" patches before this? > > Yes, it is fixing a bug that was found by clang thanks to adopting > CheckedLock. Yes, the CheckedLock patches I have landed include some fixes > but not many. Mostly our code was correct (Thankfully). I have split this fix to Bug 226059 to make it more obvious. Created attachment 429249 [details]
Patch
Created attachment 429254 [details]
Patch
Created attachment 429256 [details]
Patch
Ok, I believe I have extracted all non-trivial bug fixes out into their own patches (see related bugs). Created attachment 429308 [details]
Patch
*** Bug 226092 has been marked as a duplicate of this bug. *** Created attachment 429311 [details]
Patch
Committed r277880 (238018@main): <https://commits.webkit.org/238018@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429311 [details]. |