Summary: | Add test to ensure that an onload handler named 'onload' is called properly | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pam Greene (IRC:pamg) <pam> | ||||
Component: | DOM | Assignee: | Pam Greene (IRC:pamg) <pam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Pam Greene (IRC:pamg)
2008-12-02 14:45:54 PST
Created attachment 25684 [details]
New test + result
This test is not well suited to the JS wrapper because of the onload handler.
Is this the same as fast/dom/Element/onclick-case.html?
> This test is not well suited to the JS wrapper because of the onload handler.
It is also smaller and better because is doesn't use the JS wrapper - I don't think there's any reason at all to use js-test-pre and friends in this case.
Comment on attachment 25684 [details]
New test + result
r=me
It still seems to me that this test doesn't check for anything that isn't already checked for by fast/dom/Element/onclick-case.html. Only that onload isn't necessarily the same code path as onclick, demonstrated by the fact that at one point Chromium passed the onclick test but failed this one. OK - this wasn't mentioned before, and the fix for onclick was totally generic. |