| Summary: | Allow GPU process log channels to be configured | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||
| Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | jer.noble, simon.fraser, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Eric Carlson
2021-05-20 12:19:53 PDT
Created attachment 429208 [details]
Patch
Comment on attachment 429208 [details]
Patch
r=me. I'm not entirely sure that the GPUProcessConnection will always have been created at the point where logging is configured. We may also need to add something at GPUProcessConnection time.
Created attachment 429211 [details]
Patch
(In reply to Jer Noble from comment #3) > Comment on attachment 429208 [details] > Patch > > r=me. I'm not entirely sure that the GPUProcessConnection will always have > been created at the point where logging is configured. We may also need to > add something at GPUProcessConnection time. Lets land this as-is and talk about whether or not that is worth the effort. Committed r277835 (237979@main): <https://commits.webkit.org/237979@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429211 [details]. For WebContent we send the logging channels via WebProcessCreationParameters. Can we do something similar for GPUP? (In reply to Simon Fraser (smfr) from comment #7) > For WebContent we send the logging channels via > WebProcessCreationParameters. Can we do something similar for GPUP? That's a good idea for configuration at launch, but we also need this for on the fly configuration via the Web Inspector. |