Bug 226036

Summary: Allow GPU process log channels to be configured
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: jer.noble, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Eric Carlson
Reported 2021-05-20 12:19:53 PDT
Allow GPU process log channels to be configured
Attachments
Patch (6.67 KB, patch)
2021-05-20 12:46 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (6.69 KB, patch)
2021-05-20 13:18 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-05-20 12:20:07 PDT
<rdar://problem/78271211>
Eric Carlson
Comment 2 2021-05-20 12:46:53 PDT
Created attachment 429208 [details] Patch
Jer Noble
Comment 3 2021-05-20 13:09:35 PDT
Comment on attachment 429208 [details] Patch r=me. I'm not entirely sure that the GPUProcessConnection will always have been created at the point where logging is configured. We may also need to add something at GPUProcessConnection time.
Eric Carlson
Comment 4 2021-05-20 13:18:53 PDT
Created attachment 429211 [details] Patch
Eric Carlson
Comment 5 2021-05-20 15:48:01 PDT
(In reply to Jer Noble from comment #3) > Comment on attachment 429208 [details] > Patch > > r=me. I'm not entirely sure that the GPUProcessConnection will always have > been created at the point where logging is configured. We may also need to > add something at GPUProcessConnection time. Lets land this as-is and talk about whether or not that is worth the effort.
EWS
Comment 6 2021-05-20 16:06:10 PDT
Committed r277835 (237979@main): <https://commits.webkit.org/237979@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429211 [details].
Simon Fraser (smfr)
Comment 7 2021-05-20 16:13:40 PDT
For WebContent we send the logging channels via WebProcessCreationParameters. Can we do something similar for GPUP?
Eric Carlson
Comment 8 2021-05-21 09:06:25 PDT
(In reply to Simon Fraser (smfr) from comment #7) > For WebContent we send the logging channels via > WebProcessCreationParameters. Can we do something similar for GPUP? That's a good idea for configuration at launch, but we also need this for on the fly configuration via the Web Inspector.
Note You need to log in before you can comment on or make changes to this bug.