Bug 226030

Summary: Move off UIKit IPI in WKMouseGestureRecognizer
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch none

Tim Horton
Reported 2021-05-20 11:00:41 PDT
Move off UIKit IPI in WKMouseGestureRecognizer
Attachments
Patch (3.19 KB, patch)
2021-05-20 11:01 PDT, Tim Horton 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (3.26 KB, patch)
2021-05-20 11:11 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (3.28 KB, patch)
2021-05-20 11:16 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (3.31 KB, patch)
2021-05-20 11:24 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2021-05-20 11:01:14 PDT
Created attachment 429189 [details] Patch
Tim Horton
Comment 2 2021-05-20 11:01:16 PDT
<rdar://problem/78266173>
Devin Rousso
Comment 3 2021-05-20 11:10:28 PDT
Comment on attachment 429189 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429189&action=review r=me > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1662 > + if (gestureRecognizer == _mouseGestureRecognizer) NIT: Can we merge this with the above `if`? > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1687 > + return gestureRecognizer != _mouseGestureRecognizer; I think this needs to be in `#if HAVE(UIKIT_WITH_MOUSE_SUPPORT)`.
Wenson Hsieh
Comment 4 2021-05-20 11:10:37 PDT
Comment on attachment 429189 [details] Patch r=mews (once the watch/tv builds are fixed)
Tim Horton
Comment 5 2021-05-20 11:11:43 PDT
Created attachment 429193 [details] Patch
Tim Horton
Comment 6 2021-05-20 11:16:27 PDT
Created attachment 429195 [details] Patch
Tim Horton
Comment 7 2021-05-20 11:24:51 PDT
Created attachment 429196 [details] Patch
Devin Rousso
Comment 8 2021-05-20 12:04:34 PDT
Comment on attachment 429196 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429196&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1660 > - if (gestureRecognizer != _mouseGestureRecognizer && [_mouseGestureRecognizer mouseTouch] == touch) > - return NO; > + if ([_mouseGestureRecognizer mouseTouch] == touch) > + return gestureRecognizer == _mouseGestureRecognizer; Thinking about this a bit more, I think you actually had it correct to have separate `if` for this as right now this won't `return NO;` in the case that `gestureRecognizer == _mouseGestureRecognizer && [_mouseGestureRecognizer mouseTouch] != touch`. Sorry for the trouble 😅
Tim Horton
Comment 9 2021-05-20 12:34:34 PDT
Oh dear, you're right
EWS
Comment 10 2021-05-20 12:59:42 PDT
Committed r277820 (237966@main): <https://commits.webkit.org/237966@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429195 [details].
Note You need to log in before you can comment on or make changes to this bug.