Bug 225984
| Summary: | Stop putting single pointers in their own blocks on the heap: std::unique_ptr<HashMap> and similar | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> |
| Component: | WebKit Misc. | Assignee: | Darin Adler <darin> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=225840 | ||
Darin Adler
As seen in bug 225840 we sometimes make the mistake of allocating a HashMap or other very small single pointer structure on the heap, presumably because the programmer thinks a HashMap is expensive to allocate and destroy. Since it’s not and it’s already a pointer, we should remove any instances of this pattern.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Darin Adler
*** This bug has been marked as a duplicate of bug 226068 ***