Bug 225974

Summary:

[iOS][FCR] <select multiple> picker should collapse sections when tapping anywhere on a group header

Product:

WebKit

Reporter:

Aditya Keerthi <akeerthi>

Component:

Forms

Assignee:

Aditya Keerthi <akeerthi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

iPhone / iPad

OS:

Unspecified

Attachments:

Description	Flags
Patch	wenson_hsieh: review+
Patch for landing	none

Description Aditya Keerthi 2021-05-19 10:13:45 PDT

...

Comment 1 Aditya Keerthi 2021-05-19 10:14:03 PDT

<rdar://problem/77930033>

Comment 2 Aditya Keerthi 2021-05-19 10:16:20 PDT

Created attachment 429062 [details]
Patch

Comment 3 Wenson Hsieh 2021-05-19 10:26:33 PDT

Comment on attachment 429062 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429062&action=review

r=mews

> Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm:753
> +@protocol WKSelectPickerGroupHeaderViewDelegate <NSObject>
> +- (void)didTapSelectPickerGroupHeaderView:(WKSelectPickerGroupHeaderView *)headerView;
> +@end

Nit - since this is all internal to `WKSelectPickerGroupHeaderView` and `WKSelectPickerTableViewController` anyways, can we just directly pass in the `WKSelectPickerTableViewController` and remove this protocol?

Comment 4 Aditya Keerthi 2021-05-19 10:45:18 PDT

Created attachment 429071 [details]
Patch for landing

Comment 5 Aditya Keerthi 2021-05-19 10:45:53 PDT

(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 429062 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=429062&action=review
> 
> r=mews

Thanks for the review!
 
> > Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm:753
> > +@protocol WKSelectPickerGroupHeaderViewDelegate <NSObject>
> > +- (void)didTapSelectPickerGroupHeaderView:(WKSelectPickerGroupHeaderView *)headerView;
> > +@end
> 
> Nit - since this is all internal to `WKSelectPickerGroupHeaderView` and
> `WKSelectPickerTableViewController` anyways, can we just directly pass in
> the `WKSelectPickerTableViewController` and remove this protocol?

I've removed the protocol.

Comment 6 EWS 2021-05-19 12:32:17 PDT

Committed r277743 (237915@main): <https://commits.webkit.org/237915@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429071 [details].