| Summary: | git-webkit should have a command to diff against HEAD / main | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW --- | ||
| Severity: | Normal | CC: | ap, jbedard, kocsen_chung, mjs, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=243730 | ||
| Bug Depends on: | |||
| Bug Blocks: | 239082 | ||
|
Description
Ryosuke Niwa
2021-05-19 02:33:29 PDT
Can you clarify what you’d like it to do? Just git diff HEAD? I don't know exactly what Ryosuke had in mind for this bug, but in my opinion, this basically translates to "show me the set of changes I have locally that do not appear on the remote". This is important for style checking and for generating a pretty-diff, which is a function that is currently tied to bugzilla's patch review. This seems akin to a `git diff (--cached) (HEAD|main)`. Unless we want `git-webkit` to do anything different like the pretty-patch aforementioned, then I don't think we should have `git-webkit` do this. My intent is to avoid `git-webkit` to repeat every single git command if it doesn't have additional logic or benefit to the user. (In reply to Kocsen Chung from comment #3) > This seems akin to a `git diff (--cached) (HEAD|main)`. Unless we want > `git-webkit` to do anything different like the pretty-patch aforementioned, > then I don't think we should have `git-webkit` do this. > My intent is to avoid `git-webkit` to repeat every single git command if it > doesn't have additional logic or benefit to the user. The additional benefit is that you don't have to remember to type cryptic options like --cached / --index or HEAD/main. After 10 years of using Git, I can never bother to remember all these random names and commands because they don't make slightest of logical sense. |