Bug 22596

Summary: Some elements don't report AXBlockQuoteLevel
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Patch to return blockquote level for all elements sullivan: review+

Description chris fleizach 2008-12-02 12:08:12 PST
Elements that are not render objects are not returning their block quote level
Comment 1 chris fleizach 2008-12-02 12:38:35 PST
Created attachment 25678 [details]
Patch to return blockquote level for all elements
Comment 2 John Sullivan 2008-12-02 13:19:43 PST
Comment on attachment 25678 [details]
Patch to return blockquote level for all elements


> +        if ([attributeName isEqualToString: NSAccessibilityBlockQuoteLevelAttribute])

Our style is to not have a space between colons and parameters in ObjC method calls. I see that the current code here is inconsistent, but it would be good to eliminate this space in new code (at least).

> +            return [m_object->parentObjectUnignored()->wrapper() accessibilityAttributeValue:NSAccessibilityBlockQuoteLevelAttribute];        
>      }

r=me, assuming you are sure that m_object and m_object->parentObjectUnignored() are guaranteed to be non-0.
Comment 3 Mark Rowe (bdash) 2009-01-12 23:40:25 PST
This was landed in <http://trac.webkit.org/changeset/38915>.