Bug 225957

Summary: allowsContentJavaScript API not applied from defaultWebpagePreferences
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, darin, ggaren, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Tim Horton 2021-05-18 19:16:10 PDT
allowsContentJavaScript API not applied from defaultWebpagePreferences
Comment 1 Tim Horton 2021-05-18 19:16:28 PDT
Created attachment 429022 [details]
Patch
Comment 2 Tim Horton 2021-05-18 19:16:40 PDT
I checked, this is the only one missing.
Comment 3 EWS 2021-05-18 20:11:03 PDT
Committed r277713 (237892@main): <https://commits.webkit.org/237892@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429022 [details].
Comment 4 Radar WebKit Bug Importer 2021-05-18 20:12:17 PDT
<rdar://problem/78186580>
Comment 5 Darin Adler 2021-05-19 10:34:41 PDT
Comment on attachment 429022 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429022&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:443
> +    RetainPtr<WKWebpagePreferences> preferences = adoptNS([[WKWebpagePreferences alloc] init]);

auto

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:446
> +    RetainPtr<WKWebViewConfiguration> configuration = adoptNS([[WKWebViewConfiguration alloc] init]);

auto

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:449
> +    RetainPtr<TestWKWebView> webView = adoptNS([[TestWKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]);

auto