Bug 225938

Summary: REGRESSION (r275013): Trying to navigate in a WKWebView from a command line tool crashes the Web Content process
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ggaren, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Tim Horton
Reported 2021-05-18 14:31:26 PDT
REGRESSION (r275013): Trying to navigate in a WKWebView from a command line tool crashes the Web Content process
Attachments
Patch (3.11 KB, patch)
2021-05-18 14:31 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2021-05-18 14:31:41 PDT
Created attachment 428981 [details] Patch
Tim Horton
Comment 2 2021-05-18 14:31:43 PDT
<rdar://problem/78029118>
Alex Christensen
Comment 3 2021-05-18 14:49:33 PDT
Comment on attachment 428981 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428981&action=review > Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h:122 > + delegate.getClientBundleIdentifier(parameters.clientBundleIdentifier); It would be nice if you could make these not return-by-reference. This looks like it has no side effects, but it does.
Tim Horton
Comment 4 2021-05-18 14:52:26 PDT
Agreed, this code could be much more clear.
EWS
Comment 5 2021-05-18 15:34:19 PDT
Committed r277683 (237883@main): <https://commits.webkit.org/237883@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428981 [details].
Note You need to log in before you can comment on or make changes to this bug.