Bug 225938 - REGRESSION (r275013): Trying to navigate in a WKWebView from a command line tool crashes the Web Content process
Summary: REGRESSION (r275013): Trying to navigate in a WKWebView from a command line t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-18 14:31 PDT by Tim Horton
Modified: 2021-05-18 15:34 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.11 KB, patch)
2021-05-18 14:31 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2021-05-18 14:31:26 PDT 
REGRESSION (r275013): Trying to navigate in a WKWebView from a command line tool crashes the Web Content process
Comment 1 Tim Horton 2021-05-18 14:31:41 PDT 
Created attachment 428981 [details]
Patch
Comment 2 Tim Horton 2021-05-18 14:31:43 PDT 
<rdar://problem/78029118>
Comment 3 Alex Christensen 2021-05-18 14:49:33 PDT 
Comment on attachment 428981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428981&action=review

> Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h:122
> +    delegate.getClientBundleIdentifier(parameters.clientBundleIdentifier);

It would be nice if you could make these not return-by-reference.  This looks like it has no side effects, but it does.
Comment 4 Tim Horton 2021-05-18 14:52:26 PDT 
Agreed, this code could be much more clear.
Comment 5 EWS 2021-05-18 15:34:19 PDT 
Committed r277683 (237883@main): <https://commits.webkit.org/237883@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428981 [details].