Bug 225933

Summary:

[webkitpy] Forward booted simulators to children processes

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, commit-queue, ews-watchlist, glenn, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=225427

Bug Depends on:

225954

Bug Blocks:

Attachments:

Description	Flags
Patch	none
[fast-cq] Patch for landing	none
Patch	none
Patch for landing	none

Jonathan Bedard

Reported 2021-05-18 13:16:10 PDT

Booted simulators need to be forwarded to children processes for iOS Simulator API tests to work.

Attachments
Patch (3.04 KB, patch) 2021-05-18 13:29 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
[fast-cq] Patch for landing (3.03 KB, patch) 2021-05-18 13:41 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (3.36 KB, patch) 2021-05-19 08:00 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch for landing (3.37 KB, patch) 2021-05-20 07:20 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-05-18 13:16:25 PDT

<rdar://problem/78169900>

Jonathan Bedard

Comment 2 2021-05-18 13:29:37 PDT

Created attachment 428975 [details] Patch

Aakash Jain

Comment 3 2021-05-18 13:33:45 PDT

Comment on attachment 428975 [details] Patch rs=me

Jonathan Bedard

Comment 4 2021-05-18 13:41:59 PDT

Created attachment 428976 [details] [fast-cq] Patch for landing

EWS

Comment 5 2021-05-18 13:58:40 PDT

Committed r277675 (237876@main): <https://commits.webkit.org/237876@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428976 [details].

Tim Horton

Comment 6 2021-05-18 18:40:48 PDT

I think this broke API testing on macOS.

WebKit Commit Bot

Comment 7 2021-05-18 18:46:30 PDT

Re-opened since this is blocked by bug 225954

Alexey Proskuryakov

Comment 8 2021-05-18 18:47:33 PDT

Reverting - better to have API tests work on macOS at least.

Jonathan Bedard

Comment 9 2021-05-19 08:00:56 PDT

Created attachment 429049 [details] Patch

Aakash Jain

Comment 10 2021-05-20 07:09:31 PDT

rs=me

Jonathan Bedard

Comment 11 2021-05-20 07:20:30 PDT

Created attachment 429169 [details] Patch for landing

EWS

Comment 12 2021-05-20 07:45:37 PDT

Committed r277782 (237943@main): <https://commits.webkit.org/237943@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429169 [details].

Note You need to log in before you can comment on or make changes to this bug.