| Summary: | Commits updater should ignore null revision identifier | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zhifei Fang <zhifei_fang> | ||||||
| Component: | New Bugs | Assignee: | Zhifei Fang <zhifei_fang> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dewei_zhu, jbedard, rniwa, webkit-bug-importer, zhifei_fang | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Zhifei Fang
2021-05-18 02:05:41 PDT
Created attachment 428920 [details]
Patch
We should ignore
{
...
revisionIdentifier: null
}
As the sync_commit.py will submit such format when sync with normal git repo
Comment on attachment 428920 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428920&action=review > Websites/perf.webkit.org/public/include/commit-updater.php:172 > - if (array_key_exists('revisionIdentifier', $commit_info)) > + if (array_key_exists('revisionIdentifier', $commit_info) && isset($commit_info['revisionIdentifier'])) Can we add a test for this? This seems like a pretty serious oversight in our testing. Created attachment 428960 [details]
Patch
Comment on attachment 428960 [details]
Patch
Great. Thanks for the tests!
Committed r277671 (237872@main): <https://commits.webkit.org/237872@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428960 [details]. |