Bug 225911

Summary: Commits updater should ignore null revision identifier
Product: WebKit Reporter: Zhifei Fang <zhifei_fang>
Component: New BugsAssignee: Zhifei Fang <zhifei_fang>
Status: RESOLVED FIXED    
Severity: Normal CC: dewei_zhu, jbedard, rniwa, webkit-bug-importer, zhifei_fang
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Zhifei Fang
Reported 2021-05-18 02:05:41 PDT
Commits updater should ignore null revision identifier
Attachments
Patch (1.60 KB, patch)
2021-05-18 02:06 PDT, Zhifei Fang 		no flags
DetailsFormatted DiffDiff
Patch (12.87 KB, patch)
2021-05-18 12:05 PDT, Zhifei Fang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zhifei Fang
Comment 1 2021-05-18 02:06:05 PDT
Created attachment 428920 [details] Patch
Zhifei Fang
Comment 2 2021-05-18 02:08:05 PDT
We should ignore { ... revisionIdentifier: null } As the sync_commit.py will submit such format when sync with normal git repo
Ryosuke Niwa
Comment 3 2021-05-18 02:31:06 PDT
Comment on attachment 428920 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428920&action=review > Websites/perf.webkit.org/public/include/commit-updater.php:172 > - if (array_key_exists('revisionIdentifier', $commit_info)) > + if (array_key_exists('revisionIdentifier', $commit_info) && isset($commit_info['revisionIdentifier'])) Can we add a test for this? This seems like a pretty serious oversight in our testing.
Zhifei Fang
Comment 4 2021-05-18 12:05:08 PDT
Created attachment 428960 [details] Patch
Ryosuke Niwa
Comment 5 2021-05-18 12:36:11 PDT
Comment on attachment 428960 [details] Patch Great. Thanks for the tests!
EWS
Comment 6 2021-05-18 12:56:11 PDT
Committed r277671 (237872@main): <https://commits.webkit.org/237872@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428960 [details].
Radar WebKit Bug Importer
Comment 7 2021-05-18 12:57:17 PDT
<rdar://problem/78168984>
Note You need to log in before you can comment on or make changes to this bug.