Bug 225908 – Use RefPtr for local ref counted objects of FrameSelection::setSelectionWithoutUpdatingAppearance

• Component: HTML Editing
• Status: RESOLVED FIXED

[Frédéric Wang (:fredw)]

.

[Radar WebKit Bug Importer]

<rdar://problem/78140308>

[Frédéric Wang (:fredw)]

Created attachment 428915 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 428915 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428915&action=review

> Source/WebCore/editing/FrameSelection.cpp:1944
> -    ContainerNode* ownerElementParent = ownerElement->parentNode();
> +    RefPtr<ContainerNode> ownerElementParent = ownerElement->parentNode();

Use makeRefPtr?

[Ryosuke Niwa]

I don't think this needs to be in the security component unless there is an actual security bug we're fixing.

[Frédéric Wang (:fredw)]

Comment on attachment 428915 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428915&action=review

>> Source/WebCore/editing/FrameSelection.cpp:1944
>> +    RefPtr<ContainerNode> ownerElementParent = ownerElement->parentNode();
> 
> Use makeRefPtr?

This needs to be cast to RefPtr<ContainerNode>. Not sure how we do that in our code... or maybe you mean adding makeRefPtr in any case?

[Frédéric Wang (:fredw)]

(In reply to Ryosuke Niwa from comment #4)
> I don't think this needs to be in the security component unless there is an
> actual security bug we're fixing.

Yeah, reading the code, I don't think any of this use is "dangerous".

[Ryosuke Niwa]

Comment on attachment 428915 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428915&action=review

>>> Source/WebCore/editing/FrameSelection.cpp:1944
>>> +    RefPtr<ContainerNode> ownerElementParent = ownerElement->parentNode();
>> 
>> Use makeRefPtr?
> 
> This needs to be cast to RefPtr<ContainerNode>. Not sure how we do that in our code... or maybe you mean adding makeRefPtr in any case?

I'm confused. Given Node::parentNode() returns ContainerNode, calling makeRefPtr will surely make it RefPtr<ContainerNode>?

[Frédéric Wang (:fredw)]

Comment on attachment 428915 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428915&action=review

>>>> Source/WebCore/editing/FrameSelection.cpp:1944
>>>> +    RefPtr<ContainerNode> ownerElementParent = ownerElement->parentNode();
>>> 
>>> Use makeRefPtr?
>> 
>> This needs to be cast to RefPtr<ContainerNode>. Not sure how we do that in our code... or maybe you mean adding makeRefPtr in any case?
> 
> I'm confused. Given Node::parentNode() returns ContainerNode, calling makeRefPtr will surely make it RefPtr<ContainerNode>?

OK, I stand corrected. I had build errors when I tried yesterday, but probably that was something else. Will update the patch and land it.

[Frédéric Wang (:fredw)]

Created attachment 428923 [details]
Patch for landing

[EWS]

Committed r277647 (237853@main): <https://commits.webkit.org/237853@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428923 [details].