Bug 22589

Summary: Cleaned up SegmentedVector by abstracting segment access into helper functions
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: JavaScriptCoreAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
patch none

Geoffrey Garen
Reported 2008-12-01 22:11:59 PST
Patch coming.
Attachments
patch (7.25 KB, patch)
2008-12-01 22:12 PST, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2008-12-01 22:12:17 PST
Created attachment 25663 [details] patch Haven't run SunSpider yet.
Sam Weinig
Comment 2 2008-12-02 05:52:03 PST
Comment on attachment 25663 [details] patch r=me. Very nice cleanup!
Geoffrey Garen
Comment 3 2008-12-02 13:31:31 PST
Blergh. Crashes on SunSpider in release builds only. Here's a reduction: (function () { for ( ; false; ) { for ( ; false; ) { } continue; } })();
Geoffrey Garen
Comment 4 2008-12-02 13:32:16 PST
Crashes beneath BytecodeGenerator::continueTarget when calling SegmentedVector::removeLast.
Geoffrey Garen
Comment 5 2008-12-02 16:13:25 PST
Turns out the crash was due to out-of-date object files. Clean build fixed it.
Geoffrey Garen
Comment 6 2008-12-02 16:17:27 PST
Committed revision 38925.
Note You need to log in before you can comment on or make changes to this bug.