| Summary: | Drop unnecessary SQLiteDatabase::updateLastChangesCount() | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
| Component: | WebCore Misc. | Assignee: | Chris Dumez <cdumez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, beidson, darin, ggaren, sam, sihui_liu, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=46070 | ||||||
| Attachments: |
|
||||||
|
Description
Chris Dumez
2021-05-17 14:04:47 PDT
Created attachment 428868 [details]
Patch
Comment on attachment 428868 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428868&action=review > Source/WebCore/ChangeLog:10 > + + sqlite3_total_changes() in https://commits.webkit.org/r130891 to address an issue in WebSQL I wonder how this "Christophe Dumez" feels about us undoing his hard work. (In reply to Alex Christensen from comment #2) > Comment on attachment 428868 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=428868&action=review > > > Source/WebCore/ChangeLog:10 > > + + sqlite3_total_changes() in https://commits.webkit.org/r130891 to address an issue in WebSQL > > I wonder how this "Christophe Dumez" feels about us undoing his hard work. muhahah, I was so surprised when I saw I did this. It was so long ago. Committed r277618 (237833@main): <https://commits.webkit.org/237833@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428868 [details]. |