Bug 225885

Summary: Drop unnecessary SQLiteDatabase::updateLastChangesCount()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, darin, ggaren, sam, sihui_liu, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=46070
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2021-05-17 14:04:47 PDT
Drop unnecessary SQLiteDatabase::updateLastChangesCount().
Attachments
Patch (6.22 KB, patch)
2021-05-17 14:10 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-05-17 14:10:52 PDT
Created attachment 428868 [details] Patch
Alex Christensen
Comment 2 2021-05-17 16:25:16 PDT
Comment on attachment 428868 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428868&action=review > Source/WebCore/ChangeLog:10 > + + sqlite3_total_changes() in https://commits.webkit.org/r130891 to address an issue in WebSQL I wonder how this "Christophe Dumez" feels about us undoing his hard work.
Chris Dumez
Comment 3 2021-05-17 16:26:15 PDT
(In reply to Alex Christensen from comment #2) > Comment on attachment 428868 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=428868&action=review > > > Source/WebCore/ChangeLog:10 > > + + sqlite3_total_changes() in https://commits.webkit.org/r130891 to address an issue in WebSQL > > I wonder how this "Christophe Dumez" feels about us undoing his hard work. muhahah, I was so surprised when I saw I did this. It was so long ago.
EWS
Comment 4 2021-05-17 17:11:47 PDT
Committed r277618 (237833@main): <https://commits.webkit.org/237833@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428868 [details].
Radar WebKit Bug Importer
Comment 5 2021-05-17 17:12:26 PDT
<rdar://problem/78129682>
Note You need to log in before you can comment on or make changes to this bug.