Bug 225884

Summary: [iOS] Stop soft linking UIKit function in WebCore
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: NEW    
Severity: Normal CC: bfulgham, ddkilzer, ggaren, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch thorton: review-

Per Arne Vollan
Reported 2021-05-17 13:58:22 PDT
For performance reasons, stop soft linking UIAccessibilityIsInvertColorsEnabled.
Attachments
Patch (1.28 KB, patch)
2021-05-17 13:59 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (1.52 KB, patch)
2021-05-17 14:38 PDT, Per Arne Vollan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (1.50 KB, patch)
2021-05-17 15:33 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (1.71 KB, patch)
2021-05-17 15:46 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (2.87 KB, patch)
2021-05-18 07:34 PDT, Per Arne Vollan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (6.05 KB, patch)
2021-05-18 07:49 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (6.30 KB, patch)
2021-05-18 11:05 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (7.00 KB, patch)
2021-05-18 12:05 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (7.13 KB, patch)
2021-05-19 07:21 PDT, Per Arne Vollan 		thorton: review-
DetailsFormatted DiffDiff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2021-05-17 13:59:49 PDT
Created attachment 428864 [details] Patch
Per Arne Vollan
Comment 2 2021-05-17 14:38:04 PDT
Created attachment 428874 [details] Patch
Per Arne Vollan
Comment 3 2021-05-17 15:33:08 PDT
Created attachment 428879 [details] Patch
Per Arne Vollan
Comment 4 2021-05-17 15:46:17 PDT
Created attachment 428881 [details] Patch
Per Arne Vollan
Comment 5 2021-05-18 07:34:11 PDT
Created attachment 428934 [details] Patch
Per Arne Vollan
Comment 6 2021-05-18 07:49:28 PDT
Created attachment 428937 [details] Patch
Per Arne Vollan
Comment 7 2021-05-18 11:05:43 PDT
Created attachment 428955 [details] Patch
Per Arne Vollan
Comment 8 2021-05-18 12:05:08 PDT
Created attachment 428961 [details] Patch
Per Arne Vollan
Comment 9 2021-05-19 07:21:46 PDT
Created attachment 429047 [details] Patch
Radar WebKit Bug Importer
Comment 10 2021-05-19 07:22:42 PDT
<rdar://problem/78204423>
Per Arne Vollan
Comment 11 2021-05-19 07:26:54 PDT
<rdar://76012088>
Tim Horton
Comment 12 2021-05-19 09:57:45 PDT
WebCore cannot link UIKit.
Tim Horton
Comment 13 2021-05-19 10:10:27 PDT
(The correct layering would see you delegate this to WebKit and implement it there, but WebKitLegacy can’t link UIKit either so you’d have to further delegate out to UIKit in the WebKitLegacy case.)
Per Arne Vollan
Comment 14 2021-05-19 10:35:43 PDT
(In reply to Tim Horton from comment #13) > (The correct layering would see you delegate this to WebKit and implement it > there, but WebKitLegacy can’t link UIKit either so you’d have to further > delegate out to UIKit in the WebKitLegacy case.) Ah, got it! Thanks for reviewing!
David Kilzer (:ddkilzer)
Comment 15 2024-03-29 08:41:10 PDT
I think we have to use upward linking to solve this, but we have to do it for all UIKit symbols used in WebCore.
Note You need to log in before you can comment on or make changes to this bug.