Summary: | [iOS] Stop soft linking UIKit function in WebCore | ||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||||||||||||||||||
Component: | WebKit Misc. | Assignee: | Per Arne Vollan <pvollan> | ||||||||||||||||||||
Status: | NEW --- | ||||||||||||||||||||||
Severity: | Normal | CC: | bfulgham, ddkilzer, ggaren, thorton, webkit-bug-importer | ||||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||
Attachments: |
|
Description
Per Arne Vollan
2021-05-17 13:58:22 PDT
Created attachment 428864 [details]
Patch
Created attachment 428874 [details]
Patch
Created attachment 428879 [details]
Patch
Created attachment 428881 [details]
Patch
Created attachment 428934 [details]
Patch
Created attachment 428937 [details]
Patch
Created attachment 428955 [details]
Patch
Created attachment 428961 [details]
Patch
Created attachment 429047 [details]
Patch
WebCore cannot link UIKit. (The correct layering would see you delegate this to WebKit and implement it there, but WebKitLegacy can’t link UIKit either so you’d have to further delegate out to UIKit in the WebKitLegacy case.) (In reply to Tim Horton from comment #13) > (The correct layering would see you delegate this to WebKit and implement it > there, but WebKitLegacy can’t link UIKit either so you’d have to further > delegate out to UIKit in the WebKitLegacy case.) Ah, got it! Thanks for reviewing! I think we have to use upward linking to solve this, but we have to do it for all UIKit symbols used in WebCore. |