Bug 225831

Summary: Turn callGetter() / callSetter() into instance methods
Product: WebKit Reporter: Alexey Shvayka <ashvayka>
Component: JavaScriptCoreAssignee: Alexey Shvayka <ashvayka>
Status: RESOLVED FIXED    
Severity: Enhancement CC: ews-watchlist, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Alexey Shvayka
Reported 2021-05-14 15:36:38 PDT
Turn callGetter() / callSetter() into instance methods
Attachments
Patch (9.50 KB, patch)
2021-05-14 15:44 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Patch (12.50 KB, patch)
2021-05-15 05:41 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Shvayka
Comment 1 2021-05-14 15:44:35 PDT
Created attachment 428676 [details] Patch
Alexey Shvayka
Comment 2 2021-05-14 15:45:31 PDT
(In reply to Alexey Shvayka from comment #1) > Created attachment 428676 [details] > Patch Consistent progression (> 10 runs) @ --outer 200: r277503 patch put-slow-no-cache-setter 49.5560+-0.4171 ^ 48.4014+-0.3762 ^ definitely 1.0239x faster
Ross Kirsling
Comment 3 2021-05-14 15:54:54 PDT
Comment on attachment 428676 [details] Patch r=me, patch looks straightforward and the little perf bump is nice.
Alexey Shvayka
Comment 4 2021-05-15 05:41:53 PDT
Created attachment 428724 [details] Patch Move isValidCallee() to JSCell and handle primitives gracefully.
Alexey Shvayka
Comment 5 2021-05-15 05:44:05 PDT
(In reply to Ross Kirsling from comment #3) > Comment on attachment 428676 [details] > Patch > > r=me, patch looks straightforward and the little perf bump is nice. Thank you for review!
EWS
Comment 6 2021-05-15 10:00:05 PDT
Committed r277541 (237769@main): <https://commits.webkit.org/237769@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428724 [details].
Radar WebKit Bug Importer
Comment 7 2021-05-15 10:01:19 PDT
<rdar://problem/78059745>
Note You need to log in before you can comment on or make changes to this bug.