| Summary: | Turn callGetter() / callSetter() into instance methods | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Shvayka <ashvayka> | ||||||
| Component: | JavaScriptCore | Assignee: | Alexey Shvayka <ashvayka> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Enhancement | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Alexey Shvayka
2021-05-14 15:36:38 PDT
Created attachment 428676 [details]
Patch
(In reply to Alexey Shvayka from comment #1) > Created attachment 428676 [details] > Patch Consistent progression (> 10 runs) @ --outer 200: r277503 patch put-slow-no-cache-setter 49.5560+-0.4171 ^ 48.4014+-0.3762 ^ definitely 1.0239x faster Comment on attachment 428676 [details]
Patch
r=me, patch looks straightforward and the little perf bump is nice.
Created attachment 428724 [details]
Patch
Move isValidCallee() to JSCell and handle primitives gracefully.
(In reply to Ross Kirsling from comment #3) > Comment on attachment 428676 [details] > Patch > > r=me, patch looks straightforward and the little perf bump is nice. Thank you for review! Committed r277541 (237769@main): <https://commits.webkit.org/237769@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428724 [details]. |