Bug 225798

Summary: Rename FileSystem::getFileSize() to FileSystem::fileSize()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web Template FrameworkAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, beidson, benjamin, cgarcia, changseok, cmarcelo, darin, esprehn+autocc, ews-watchlist, galpeter, ggaren, glenn, hi, japhet, joepeck, jsbell, keith_miller, kondapallykalyan, mark.lam, mifenton, msaboff, pdr, saam, sam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch none

Chris Dumez
Reported 2021-05-13 21:39:54 PDT
Rename FileSystem::getFileSize() to FileSystem::fileSize(). Also have it return an Optional<uint64_t> instead of taking a long long out-parameter.
Attachments
Patch (56.26 KB, patch)
2021-05-13 21:49 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (56.25 KB, patch)
2021-05-13 22:07 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-05-13 21:49:50 PDT
Created attachment 428601 [details] Patch
Chris Dumez
Comment 2 2021-05-13 22:07:18 PDT
Created attachment 428602 [details] Patch
EWS
Comment 3 2021-05-14 09:10:46 PDT
Committed r277492 (237726@main): <https://commits.webkit.org/237726@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428602 [details].
Radar WebKit Bug Importer
Comment 4 2021-05-14 09:11:17 PDT
<rdar://problem/78019212>
Note You need to log in before you can comment on or make changes to this bug.