Bug 225782

Summary: Work around WebCore failing to build due to NDEBUG getting undefined in release
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 226709    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Tim Horton
Reported 2021-05-13 14:14:08 PDT
Work around WebCore failing to build due to NDEBUG getting undefined in release
Attachments
Patch (1.65 KB, patch)
2021-05-13 14:14 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (4.10 KB, patch)
2021-05-13 15:18 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2021-05-13 14:14:37 PDT
Created attachment 428560 [details] Patch
Tim Horton
Comment 2 2021-05-13 14:14:39 PDT
<rdar://problem/77982432>
Alexey Proskuryakov
Comment 3 2021-05-13 14:16:44 PDT
Comment on attachment 428560 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428560&action=review > Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:52 > +#if defined(WK_NDEBUG) && !defined(NDEBUG) I'd undef WK_NDEBUG here, as leaking debug related defines from headers just doesn't feel good right now.
Tim Horton
Comment 4 2021-05-13 14:27:35 PDT
Fair point :)
Tim Horton
Comment 5 2021-05-13 15:18:58 PDT
Created attachment 428568 [details] Patch
EWS
Comment 6 2021-05-13 16:27:28 PDT
Committed r277464 (237707@main): <https://commits.webkit.org/237707@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428568 [details].
WebKit Commit Bot
Comment 7 2021-06-06 23:30:06 PDT
Re-opened since this is blocked by bug 226709
Note You need to log in before you can comment on or make changes to this bug.