Bug 225775

Summary: [Cocoa] Plumb data detector results through some platform objects
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: PlatformAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, annulen, ews-watchlist, gyuyoung.kim, hi, megan_gardner, mifenton, ryuan.choi, sergio, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Fix non-internal builds
none
For EWS none

Description Wenson Hsieh 2021-05-13 12:29:46 PDT 
Work towards rdar://75504956.
Comment 1 Wenson Hsieh 2021-05-13 16:06:16 PDT 
Created attachment 428570 [details]
Patch
Comment 2 Wenson Hsieh 2021-05-13 16:16:47 PDT 
Created attachment 428571 [details]
Fix non-internal builds
Comment 3 Devin Rousso 2021-05-13 16:19:07 PDT 
Comment on attachment 428570 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428570&action=review

r=mews

> Source/WebCore/SourcesCocoa.txt:-240
> -platform/cocoa/DataDetectorsCoreSoftLink.mm @no-unify

Do you need to add this to another `SourcesCocoa.txt` and/or `.cmake` file in PAL?

> Source/WebKit/Shared/WebCoreArgumentCoders.cpp:3225
> +    return { WTFMove(result) };

NIT: I think you can drop the `{` `}`
Comment 4 Wenson Hsieh 2021-05-13 16:24:12 PDT 
(In reply to Devin Rousso from comment #3)
> Comment on attachment 428570 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=428570&action=review
> 
> r=mews
> 
> > Source/WebCore/SourcesCocoa.txt:-240
> > -platform/cocoa/DataDetectorsCoreSoftLink.mm @no-unify
> 
> Do you need to add this to another `SourcesCocoa.txt` and/or `.cmake` file
> in PAL?

PAL doesn't build with unified sources. However, there is a cmake file for PAL; I added the new headers there.

> 
> > Source/WebKit/Shared/WebCoreArgumentCoders.cpp:3225
> > +    return { WTFMove(result) };
> 
> NIT: I think you can drop the `{` `}`

👍🏻
Comment 5 Wenson Hsieh 2021-05-13 17:40:53 PDT 
Created attachment 428584 [details]
For EWS
Comment 6 EWS 2021-05-13 21:06:45 PDT 
Committed r277479 (237714@main): <https://commits.webkit.org/237714@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428584 [details].