Bug 22574

Summary:

[GTK] Make webkit_web_view_set_window_features internal

Product:

WebKit

Reporter:

Holger Freyther <zecke>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

Gtk

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Make webkit_web_view_set_window_features internal	none

Holger Freyther

Reported 2008-12-01 14:53:07 PST

Make webkit_web_view_set_window_features internal as it has the risk of missing a notify::window-features and there is no need to set that from the outside.

Attachments
Make webkit_web_view_set_window_features internal (5.05 KB, patch) 2008-12-01 14:56 PST, Holger Freyther	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Holger Freyther

Comment 1 2008-12-01 14:56:37 PST

Created attachment 25638 [details] Make webkit_web_view_set_window_features internal Make it internal, switch the user of this function over to use g_object_set.

Holger Freyther

Comment 2 2008-12-11 17:31:43 PST

Landed in r39223.

Holger Freyther

Comment 3 2008-12-19 09:17:08 PST

Comment on attachment 25638 [details] Make webkit_web_view_set_window_features internal Clear review, it was reviewed and landed.

Note You need to log in before you can comment on or make changes to this bug.