Summary: | Delete WebSQL code from WebKit2 | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||||||||
Component: | WebKit2 | Assignee: | Ryosuke Niwa <rniwa> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, jer.noble, kkinnunen, philipj, sam, sergio, sihui_liu, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Ryosuke Niwa
2021-05-13 02:40:17 PDT
Created attachment 428478 [details]
Patch
Comment on attachment 428478 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428478&action=review > Source/WebKit/ChangeLog:17 > + (WebKit::m_messagePortChannelRegistry): Deleted. Deleted? > Source/WebKit/ChangeLog:26 > + * Shared/WebSQLiteDatabaseTracker.cpp: Removed. > + * Shared/WebSQLiteDatabaseTracker.h: Removed. Despite its name, WebSQLiteDatabaseTracker is actually responsible for monitoring all SQLite operations (network process uses it to notify UI process to not suspend it during database operations, see SQLiteDatabaseTracker), so this seems wrong. > Source/WebKit/ChangeLog:42 > + (WebKit::m_lastNavigationWasAppBound): I didn't see related change in this patch. (In reply to Sihui Liu from comment #2) > Comment on attachment 428478 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=428478&action=review > > > Source/WebKit/ChangeLog:17 > > + (WebKit::m_messagePortChannelRegistry): Deleted. > > Deleted? > > > Source/WebKit/ChangeLog:26 > > + * Shared/WebSQLiteDatabaseTracker.cpp: Removed. > > + * Shared/WebSQLiteDatabaseTracker.h: Removed. > > Despite its name, WebSQLiteDatabaseTracker is actually responsible for > monitoring all SQLite operations (network process uses it to notify UI > process to not suspend it during database operations, see > SQLiteDatabaseTracker), so this seems wrong. Oh, I see. Created attachment 428610 [details]
Patch
Comment on attachment 428610 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428610&action=review > Source/WTF/ChangeLog:3 > + Delete WebSQL code from WebKit2 This seems to also be removing the WebKitLegacy code, is that intentional? (In reply to Sam Weinig from comment #5) > Comment on attachment 428610 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=428610&action=review > > > Source/WTF/ChangeLog:3 > > + Delete WebSQL code from WebKit2 > > This seems to also be removing the WebKitLegacy code, is that intentional? Oh yeah, that was definitely not intentional. I was going to rename it and forgot to add the new one. Created attachment 428658 [details]
Patch
Created attachment 428682 [details]
Patch for landing
Comment on attachment 428682 [details]
Patch for landing
Wait for EWS.
Created attachment 428720 [details]
Patch for landing
Comment on attachment 428720 [details]
Patch for landing
Wait for EWS.
Committed r277564 (237792@main): <https://commits.webkit.org/237792@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428720 [details]. |