Summary: | [iOS] REGRESSION(r271216) pointerevents/ios/pointer-events-no-mousedown-when-prevent-default-called-on-pointerdown.html is consistently failing | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||
Component: | New Bugs | Assignee: | Devin Rousso <hi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | graouts, hi, thorton, webkit-bug-importer, wenson_hsieh | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 220072 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Devin Rousso
2021-05-12 22:11:18 PDT
Created attachment 428459 [details]
Patch
Comment on attachment 428459 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428459&action=review > Source/WebCore/ChangeLog:14 > + Instead of fully removing the `CapturingData` entirely, change it's state such that it's Nit - the first "it's" should be "its" > Source/WebCore/page/PointerCaptureController.cpp:329 > - if (capturingData.pointerType == touchPointerEventType() && capturingData.pointerIsPressed && !capturingData.cancelled) > + if (capturingData.pointerType == touchPointerEventType() && capturingData.state == CapturingData::State::Ready) Was removing the check for `capturingData.pointerIsPressed` intentional? Comment on attachment 428459 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428459&action=review >> Source/WebCore/page/PointerCaptureController.cpp:329 >> + if (capturingData.pointerType == touchPointerEventType() && capturingData.state == CapturingData::State::Ready) > > Was removing the check for `capturingData.pointerIsPressed` intentional? Yes. This was my attempt at "only include things that are active" in r271216, but as I mentioned in the ChangeLog because mouse events are dispatched after, it'd no longer be `pointerIsPressed` by that point anyways. Created attachment 428565 [details]
Patch
Committed r277463 (237706@main): <https://commits.webkit.org/237706@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428565 [details]. |