| Summary: | [LFC] Move geometry/quirk/margincollapse classes out of their FormattingContext | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | koivisto | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 225744, 225745, 225746, 225747, 225748, 225749, 225750, 225751, 225752, 225753, 225754, 225755, 225756, 225757, 225758, 225759, 225760, 225761, 225762 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2021-05-12 20:50:56 PDT
Created attachment 428454 [details]
Patch
Created attachment 428455 [details]
Patch
This is essentially a squashed version of the following patches: Move BlockMarginCollapse to its own class Move block formatting quirks to its own class Move table wrapper quirks to its own class Move inline formatting quirks to its own class Move table formatting quirks to its own class Move base formatting quirks to its own class Move block formatting geometry to its own class Move flex formatting geometry to its own class Move table formatting geometry to its own class Move base formatting geometry to its own class Make FormattingGeometry c'tors public Make redundant public helpers private in BlockFormattingContext Make redundant public helpers private in InlineFormattingContext Make redundant public helpers private in TableFormattingContext Make redundant public helpers private in FormattingContext Cleanup FormattingQuirk classes Cleanup MarginCollapsing class Cleanup FormattingContext class Comment on attachment 428455 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428455&action=review > Source/WebCore/ChangeLog:8 > + This is just an umbrella patch. nice umbrella All the patches have been landed. Closing now. |