Bug 225711

Summary: Simplify / Modernize Notification permission implementation
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, berto, cgarcia, ews-watchlist, ggaren, gustavo, kkinnunen, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=225701
Bug Depends on:    
Bug Blocks: 225712    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Chris Dumez
Reported 2021-05-12 12:06:03 PDT
Simplify / Modernize Notification permission implementation.
Attachments
Patch (28.56 KB, patch)
2021-05-12 12:10 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (29.47 KB, patch)
2021-05-12 12:50 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (33.46 KB, patch)
2021-05-12 13:11 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (33.73 KB, patch)
2021-05-12 13:18 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (33.97 KB, patch)
2021-05-12 13:30 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-05-12 12:10:17 PDT
Created attachment 428400 [details] Patch
EWS Watchlist
Comment 2 2021-05-12 12:11:10 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Chris Dumez
Comment 3 2021-05-12 12:50:27 PDT
Created attachment 428403 [details] Patch
Alex Christensen
Comment 4 2021-05-12 12:51:56 PDT
Comment on attachment 428403 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428403&action=review > Source/WebKit/UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp:38 > +void NotificationPermissionRequestManagerProxy::invalidateRequests() Now that we're using sendWithAsyncReply, I think we might not need this any more. We might be able to completely remove the NotificationPermissionRequestManagerProxy.
Chris Dumez
Comment 5 2021-05-12 12:52:40 PDT
(In reply to Alex Christensen from comment #4) > Comment on attachment 428403 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=428403&action=review > > > Source/WebKit/UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp:38 > > +void NotificationPermissionRequestManagerProxy::invalidateRequests() > > Now that we're using sendWithAsyncReply, I think we might not need this any > more. We might be able to completely remove the > NotificationPermissionRequestManagerProxy. Oh. I may be even to drop more code then. Let me check :D
Chris Dumez
Comment 6 2021-05-12 13:11:29 PDT
Created attachment 428407 [details] Patch
Chris Dumez
Comment 7 2021-05-12 13:18:21 PDT
Created attachment 428409 [details] Patch
Chris Dumez
Comment 8 2021-05-12 13:30:54 PDT
Created attachment 428410 [details] Patch
EWS
Comment 9 2021-05-12 17:31:49 PDT
Committed r277414 (237664@main): <https://commits.webkit.org/237664@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428410 [details].
Radar WebKit Bug Importer
Comment 10 2021-05-12 17:32:19 PDT
<rdar://problem/77941877>
Note You need to log in before you can comment on or make changes to this bug.