Bug 225707

Summary: Split pixel buffer format data out into a new PixelBufferFormat struct
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, cdumez, changseok, darin, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kondapallykalyan, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Sam Weinig
Reported 2021-05-12 11:35:26 PDT
Split pixel buffer format data out into a new PixelBufferFormat struct
Attachments
Patch (51.14 KB, patch)
2021-05-12 11:51 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (52.80 KB, patch)
2021-05-12 14:17 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (52.84 KB, patch)
2021-05-13 12:06 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (53.03 KB, patch)
2021-05-13 12:29 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2021-05-12 11:51:51 PDT Comment hidden (obsolete)
Darin Adler
Comment 2 2021-05-12 12:42:21 PDT
Looks great, waiting to review until we have a version that’s a little more green on EWS.
Sam Weinig
Comment 3 2021-05-12 14:17:03 PDT
Created attachment 428419 [details] Patch
Darin Adler
Comment 4 2021-05-12 15:46:19 PDT
Comment on attachment 428419 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428419&action=review > Source/WebCore/platform/graphics/PixelBufferFormat.cpp:35 > + return ts << pixelBuffer.alphaFormat << " " << pixelBuffer.pixelFormat << " " << pixelBuffer.colorSpace; Faster if you use ' ' instead of " "? > Source/WebCore/platform/graphics/PixelBufferFormat.h:50 > + encoder << alphaFormat; > + encoder << pixelFormat; > + encoder << colorSpace; Use the one-line form? > Source/WebCore/platform/graphics/PixelFormat.h:40 > +WEBCORE_EXPORT WTF::TextStream& operator<<(WTF::TextStream&, PixelFormat); Don’t need WTF prefix.
Sam Weinig
Comment 5 2021-05-13 12:06:18 PDT
Created attachment 428542 [details] Patch
Sam Weinig
Comment 6 2021-05-13 12:29:30 PDT
Created attachment 428544 [details] Patch
EWS
Comment 7 2021-05-13 13:54:29 PDT
Committed r277450 (237698@main): <https://commits.webkit.org/237698@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428544 [details].
Radar WebKit Bug Importer
Comment 8 2021-05-13 13:55:16 PDT
<rdar://problem/77985115>
Note You need to log in before you can comment on or make changes to this bug.