| Summary: | Split pixel buffer format data out into a new PixelBufferFormat struct | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | annulen, cdumez, changseok, darin, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kondapallykalyan, ryuan.choi, sergio, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Sam Weinig
2021-05-12 11:35:26 PDT
Created attachment 428396 [details]
Patch
Looks great, waiting to review until we have a version that’s a little more green on EWS. Created attachment 428419 [details]
Patch
Comment on attachment 428419 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428419&action=review > Source/WebCore/platform/graphics/PixelBufferFormat.cpp:35 > + return ts << pixelBuffer.alphaFormat << " " << pixelBuffer.pixelFormat << " " << pixelBuffer.colorSpace; Faster if you use ' ' instead of " "? > Source/WebCore/platform/graphics/PixelBufferFormat.h:50 > + encoder << alphaFormat; > + encoder << pixelFormat; > + encoder << colorSpace; Use the one-line form? > Source/WebCore/platform/graphics/PixelFormat.h:40 > +WEBCORE_EXPORT WTF::TextStream& operator<<(WTF::TextStream&, PixelFormat); Don’t need WTF prefix. Created attachment 428542 [details]
Patch
Created attachment 428544 [details]
Patch
Committed r277450 (237698@main): <https://commits.webkit.org/237698@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428544 [details]. |