Bug 225648
| Summary: | Many canvas/media aspect-ratio failures | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Anne van Kesteren <annevk> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | cathiechen, gsnedders, rbuis, simon.fraser, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 217529 | ||
| Bug Blocks: | |||
Anne van Kesteren
In cleaning up some aspects of the specification around aspect-ratio, I found that WebKit fails a bunch of tests: https://github.com/web-platform-tests/wpt/pull/28932. Cleanup happening in https://github.com/whatwg/html/pull/6529.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Rob Buis
Cathie, IIRC you implemented this for one of video, image or canvas? We probably have existing bugs for these, which if fixed would fix these tests.
Rob Buis
I think bugs like this have to be fixed first:
https://bugs.webkit.org/show_bug.cgi?id=217529
Anne van Kesteren
Ah thanks for finding that Rob! that might be the whole issue here for all I know.
cathiechen
(In reply to Rob Buis from comment #1)
> Cathie, IIRC you implemented this for one of video, image or canvas? We
> probably have existing bugs for these, which if fixed would fix these tests.
Yeah, I'm working on implementing this for video and picture.
It seems most failures are `test_computed_style_aspect_ratio` which is related to bug 217529, i.e. implement mapping width height to aspect ratio by using CSS aspect-ratio.
Currently, the implementation in WebKit does not depend on CSS aspect-ratio.
Radar WebKit Bug Importer
<rdar://problem/78149269>