Bug 225631

Summary: [WebXR] Return a default layer handle in XRDeviceProxy::createLayerProjection
Product: WebKit Reporter: Ada Chan <adachan>
Component: New BugsAssignee: Ada Chan <adachan>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
dino: review+
Patch for landing none

Description Ada Chan 2021-05-10 18:31:12 PDT
[WebXR] Return a default layer handle in XRDeviceProxy::createLayerProjection
Comment 1 Ada Chan 2021-05-10 18:32:42 PDT
Created attachment 428233 [details]
Patch
Comment 2 Dean Jackson 2021-05-10 18:34:00 PDT
Comment on attachment 428233 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428233&action=review

> Source/WebKit/UIProcess/Cocoa/PlatformXRCoordinator.h:44
> +    static PlatformXR::LayerHandle defaultLayerHandle() { return 1; }

Maybe put a FIXME here saying it needs to be fixed.
Comment 3 Ada Chan 2021-05-10 18:56:39 PDT
Created attachment 428236 [details]
Patch for landing
Comment 4 EWS 2021-05-11 07:56:01 PDT
Committed r277324 (237583@main): <https://commits.webkit.org/237583@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428236 [details].
Comment 5 Radar WebKit Bug Importer 2021-05-11 07:56:27 PDT
<rdar://problem/77845149>