Bug 225631

Summary: [WebXR] Return a default layer handle in XRDeviceProxy::createLayerProjection
Product: WebKit Reporter: Ada Chan <adachan>
Component: New BugsAssignee: Ada Chan <adachan>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
dino: review+
Patch for landing none

Ada Chan
Reported 2021-05-10 18:31:12 PDT
[WebXR] Return a default layer handle in XRDeviceProxy::createLayerProjection
Attachments
Patch (4.92 KB, patch)
2021-05-10 18:32 PDT, Ada Chan 		dino: review+
DetailsFormatted DiffDiff
Patch for landing (4.97 KB, patch)
2021-05-10 18:56 PDT, Ada Chan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ada Chan
Comment 1 2021-05-10 18:32:42 PDT
Created attachment 428233 [details] Patch
Dean Jackson
Comment 2 2021-05-10 18:34:00 PDT
Comment on attachment 428233 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428233&action=review > Source/WebKit/UIProcess/Cocoa/PlatformXRCoordinator.h:44 > + static PlatformXR::LayerHandle defaultLayerHandle() { return 1; } Maybe put a FIXME here saying it needs to be fixed.
Ada Chan
Comment 3 2021-05-10 18:56:39 PDT
Created attachment 428236 [details] Patch for landing
EWS
Comment 4 2021-05-11 07:56:01 PDT
Committed r277324 (237583@main): <https://commits.webkit.org/237583@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428236 [details].
Radar WebKit Bug Importer
Comment 5 2021-05-11 07:56:27 PDT
<rdar://problem/77845149>
Note You need to log in before you can comment on or make changes to this bug.