| Summary: | Add support to collect stats on cumulative LinkBuffer linked sizes based on profiles. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Mark Lam
2021-05-10 14:43:53 PDT
Created attachment 428210 [details]
proposed patch.
Comment on attachment 428210 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=428210&action=review > Source/JavaScriptCore/ChangeLog:9 > + 1. Specify --dumpLinkBufferStats as an argument to the jsc shell. maybe a JSC option too? Comment on attachment 428210 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=428210&action=review > Source/JavaScriptCore/ChangeLog:10 > + 2. Call $vm.dumpLinkBufferStats() from your JS script. maybe have it return a string? (In reply to Saam Barati from comment #2) > Comment on attachment 428210 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=428210&action=review > > > Source/JavaScriptCore/ChangeLog:9 > > + 1. Specify --dumpLinkBufferStats as an argument to the jsc shell. > > maybe a JSC option too? A JSC option doesn't make sense to me because it doesn't say anything about when we should be dumping the stats. So, I'll leave this out for now. (In reply to Saam Barati from comment #3) > Comment on attachment 428210 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=428210&action=review > > > Source/JavaScriptCore/ChangeLog:10 > > + 2. Call $vm.dumpLinkBufferStats() from your JS script. > > maybe have it return a string? I'll change $vm.dumpLinkBufferStats() to $vm.linkBufferStats() and have it return the stats as a string instead. Created attachment 428215 [details]
patch for landing.
Created attachment 428216 [details]
patch for landing.
Thanks for the review. Landed in r277305: <http://trac.webkit.org/r277305>. |