RESOLVED FIXED 225617
Add support to collect stats on cumulative LinkBuffer linked sizes based on profiles. 
https://bugs.webkit.org/show_bug.cgi?id=225617
Summary Add support to collect stats on cumulative LinkBuffer linked sizes based on p...
Mark Lam
Reported 2021-05-10 14:43:53 PDT
This is used for VM development and tuning.
Attachments
proposed patch. (58.04 KB, patch)
2021-05-10 15:05 PDT, Mark Lam 		saam: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
patch for landing. (58.50 KB, patch)
2021-05-10 16:09 PDT, Mark Lam 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
patch for landing. (58.52 KB, patch)
2021-05-10 16:13 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2021-05-10 15:05:01 PDT
Created attachment 428210 [details] proposed patch.
Saam Barati
Comment 2 2021-05-10 15:11:03 PDT
Comment on attachment 428210 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=428210&action=review > Source/JavaScriptCore/ChangeLog:9 > + 1. Specify --dumpLinkBufferStats as an argument to the jsc shell. maybe a JSC option too?
Saam Barati
Comment 3 2021-05-10 15:11:39 PDT
Comment on attachment 428210 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=428210&action=review > Source/JavaScriptCore/ChangeLog:10 > + 2. Call $vm.dumpLinkBufferStats() from your JS script. maybe have it return a string?
Mark Lam
Comment 4 2021-05-10 15:15:03 PDT
(In reply to Saam Barati from comment #2) > Comment on attachment 428210 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=428210&action=review > > > Source/JavaScriptCore/ChangeLog:9 > > + 1. Specify --dumpLinkBufferStats as an argument to the jsc shell. > > maybe a JSC option too? A JSC option doesn't make sense to me because it doesn't say anything about when we should be dumping the stats. So, I'll leave this out for now.
Mark Lam
Comment 5 2021-05-10 15:42:49 PDT
(In reply to Saam Barati from comment #3) > Comment on attachment 428210 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=428210&action=review > > > Source/JavaScriptCore/ChangeLog:10 > > + 2. Call $vm.dumpLinkBufferStats() from your JS script. > > maybe have it return a string? I'll change $vm.dumpLinkBufferStats() to $vm.linkBufferStats() and have it return the stats as a string instead.
Mark Lam
Comment 6 2021-05-10 16:09:46 PDT
Created attachment 428215 [details] patch for landing.
Mark Lam
Comment 7 2021-05-10 16:13:45 PDT
Created attachment 428216 [details] patch for landing.
Mark Lam
Comment 8 2021-05-10 16:22:20 PDT
Thanks for the review. Landed in r277305: <http://trac.webkit.org/r277305>.
Radar WebKit Bug Importer
Comment 9 2021-05-10 16:23:19 PDT
<rdar://problem/77794461>
Note You need to log in before you can comment on or make changes to this bug.