Bug 225613

Summary: Speculative revalidation requests not properly attributed as app-bound
Product: WebKit Reporter: Kate Cheney <katherine_cheney>
Component: WebKit Misc.Assignee: Kate Cheney <katherine_cheney>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, cdumez, cgarcia, ews-watchlist
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Kate Cheney 2021-05-10 14:28:41 PDT 
We should attribute app-bound status to speculative revalidation requests.
Comment 1 Kate Cheney 2021-05-10 14:29:17 PDT 
<rdar://problem/77664358>
Comment 2 Kate Cheney 2021-05-10 14:56:55 PDT 
Created attachment 428206 [details]
Patch
Comment 3 Kate Cheney 2021-05-10 14:58:03 PDT 
The test for this technically relies on infrastructure added in https://bugs.webkit.org/show_bug.cgi?id=225596 (in review) but since they are skipped for open source builds this won't affect EWS.
Comment 4 Brent Fulgham 2021-05-10 15:31:49 PDT 
Comment on attachment 428206 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428206&action=review

> Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:96
> +    revalidationRequest.setIsAppBound(subResourceInfo.isAppBound());

I suggest we bundle these various "copy request state to new request" into some common function somewhere (not for this patch though).

> LayoutTests/platform/ios-wk2/TestExpectations:1794
> +http/tests/in-app-browser-privacy/app-bound-attribution-speculative-revalidation.html [ Skip ]

Why do we need to skip on iOS? Is this because of missing test features, or does the test just not work on iOS?
Comment 5 Brent Fulgham 2021-05-10 15:36:26 PDT 
Comment on attachment 428206 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428206&action=review

r=me

>> LayoutTests/platform/ios-wk2/TestExpectations:1794
>> +http/tests/in-app-browser-privacy/app-bound-attribution-speculative-revalidation.html [ Skip ]
> 
> Why do we need to skip on iOS? Is this because of missing test features, or does the test just not work on iOS?

I spoke with Kate about this offline. It's skipped in iOS on Open Source. So this is fine (and will be unskilled in future).
Comment 6 Kate Cheney 2021-05-10 16:19:34 PDT 
Created attachment 428217 [details]
Patch for landing
Comment 7 EWS 2021-05-10 16:52:46 PDT 
Committed r277306 (237567@main): <https://commits.webkit.org/237567@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428217 [details].