| Summary: | LayoutTests/imported/w3c/web-platform-tests/fonts/math/operators.woff is missing | ||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Cameron McCormack (:heycam) <heycam> | ||||||||||||||||||||||||||||||||
| Component: | Tools / Tests | Assignee: | Cameron McCormack (:heycam) <heycam> | ||||||||||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||||||||
| Severity: | Normal | CC: | amir_mark, clopez, dbarton, ews-watchlist, fred.wang, lmoura, sabouhallawa, tsavell, webkit-bug-importer, youennf | ||||||||||||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||||||||||
| Version: | WebKit Local Build | ||||||||||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||||||||||
| Bug Depends on: | 225728 | ||||||||||||||||||||||||||||||||||
| Bug Blocks: | |||||||||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||||||||
|
Description
Cameron McCormack (:heycam)
2021-05-09 22:42:17 PDT
Created attachment 428155 [details]
Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess Created attachment 428208 [details]
Patch
Created attachment 428246 [details]
Patch
Created attachment 428313 [details]
Patch
Fred or Said, could you review this? Some tests now pass, and others still fail, but now with different values due to different text metrics with the operators.woff font. Comment on attachment 428313 [details]
Patch
Thanks. LGTM. cc'ing lmoura as this will likely need rebase on GTK/WPE ports too.
I may revise the specific updates in this patch. I've just realized that some of the tests are flaky in WebKit, because of the way that the tests use document.fonts.ready() to wait until operators.woff to load. (Looks like WebKit doesn't wait for layout to be flushed, which is what would trigger the font load, before resolving the ready promise.) So I might tweak the tests to avoid that problem (since they're not testing font loading specifically), then update the expectations here afterwards. Created attachment 428808 [details]
Patch
Created attachment 428810 [details]
Patch
Created attachment 428815 [details]
Patch
Created attachment 428877 [details]
Patch
Created attachment 429010 [details]
Patch
Created attachment 429122 [details]
Patch
Created attachment 429146 [details]
Patch
Created attachment 429226 [details]
Patch
Created attachment 429388 [details]
Patch
Created attachment 429498 [details]
Patch
Committed r277970 (238092@main): <https://commits.webkit.org/238092@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429498 [details]. The changes to expectations in https://trac.webkit.org/changeset/277970/webkit has broken 9 tests: imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-minsize-maxsize-001.html [ Failure ] imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-stretch-properties-dynamic-001.html [ Failure ] imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-combining.html [ Failure ] imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-001.html [ Failure ] imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-002.html [ Failure ] imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-001.html [ Failure ] imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-005.html [ Failure ] imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-006.html [ Failure ] imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002.html [ Failure ] Test Results: https://build.webkit.org/results/Apple-BigSur-Release-WK1-Tests/r278042%20(3014)/results.html *** Bug 226246 has been marked as a duplicate of this bug. *** Created attachment 429728 [details]
Followup test expectation updates
Committed r278079 (238158@main): <https://commits.webkit.org/238158@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429728 [details]. |