Bug 22557

Summary: Better memory statistics
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
patch
none
JS GC heap statistics
none
Report free memory in central and thread caches too. none

Antti Koivisto
Reported 2008-11-29 13:26:47 PST
We should have way to get statistics about fast malloc heap and purgeable memory.
Attachments
patch (7.48 KB, patch)
2008-11-29 13:30 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
JS GC heap statistics (5.06 KB, patch)
2008-11-29 22:37 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Report free memory in central and thread caches too. (4.51 KB, patch)
2008-11-30 13:58 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2008-11-29 13:30:04 PST
Created attachment 25600 [details] patch
Alexey Proskuryakov
Comment 2 2008-11-29 13:54:29 PST
Comment on attachment 25600 [details] patch + size_t ReturnedBytes() const; Is that an extra space before size_t? Please consider putting these functions in global namespace with "using" for consistency with most of WTF. r=me
Antti Koivisto
Comment 3 2008-11-29 14:10:52 PST
Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/JavaScriptCore.exp Sending JavaScriptCore/wtf/FastMalloc.cpp Sending JavaScriptCore/wtf/FastMalloc.h Sending WebKit/mac/ChangeLog Sending WebKit/mac/Misc/WebCache.mm Sending WebKit/mac/Misc/WebCoreStatistics.h Sending WebKit/mac/Misc/WebCoreStatistics.mm Transmitting file data ........ Committed revision 38844.
Antti Koivisto
Comment 4 2008-11-29 14:11:51 PST
I didn't move the functions to global namaspace since I didn't understand the reasoning.
Antti Koivisto
Comment 5 2008-11-29 22:20:34 PST
Reopening for another patch.
Antti Koivisto
Comment 6 2008-11-29 22:20:53 PST
Comment on attachment 25600 [details] patch Clearing old review flag.
Antti Koivisto
Comment 7 2008-11-29 22:37:00 PST
Created attachment 25606 [details] JS GC heap statistics
Antti Koivisto
Comment 8 2008-11-29 23:25:41 PST
Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/JavaScriptCore.exp Sending JavaScriptCore/runtime/Collector.cpp Sending JavaScriptCore/runtime/Collector.h Sending WebKit/mac/ChangeLog Sending WebKit/mac/Misc/WebCoreStatistics.mm Transmitting file data ...... Committed revision 38849.
Antti Koivisto
Comment 9 2008-11-30 13:57:43 PST
Add free size in caches.
Antti Koivisto
Comment 10 2008-11-30 13:58:49 PST
Created attachment 25617 [details] Report free memory in central and thread caches too.
Mark Rowe (bdash)
Comment 11 2008-11-30 14:06:40 PST
Comment on attachment 25617 [details] Report free memory in central and thread caches too. r=me if you fix up the non-TCMalloc code to avoid breaking the debug build.
Antti Koivisto
Comment 12 2008-11-30 14:26:24 PST
Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/wtf/FastMalloc.cpp Sending JavaScriptCore/wtf/FastMalloc.h Sending WebKit/mac/ChangeLog Sending WebKit/mac/Misc/WebCoreStatistics.mm Transmitting file data ..... Committed revision 38853.
Note You need to log in before you can comment on or make changes to this bug.