Bug 225553

Summary: Introduce JSObject::getIfPropertyExists helper
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: New BugsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: ashvayka, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
ews-feeder: commit-queue-
Patch for landing none

Ross Kirsling
Reported 2021-05-07 20:03:42 PDT
Introduce JSObject::getIfPropertyExists helper
Attachments
Patch (6.63 KB, patch)
2021-05-07 20:07 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.56 KB, patch)
2021-05-07 23:43 PDT, Ross Kirsling 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (6.57 KB, patch)
2021-05-07 23:47 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2021-05-07 20:07:31 PDT
Created attachment 428074 [details] Patch
Alexey Shvayka
Comment 2 2021-05-07 20:41:26 PDT
Comment on attachment 428074 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428074&action=review Sweet! Thank you for the follow-up. I presume there might be more usages for getIfPropertyExists() in future (like around GetBindingValue). r=me with error handling suggestion. > Source/JavaScriptCore/runtime/JSObjectInlines.h:205 > + Since getIfPropertyExists() call sites should check exception either way, I think we can completely drop exception handling from this helper. At this point (hasProperty: true), we are guaranteed to be exception-free, and can just return the ternary expression.
Ross Kirsling
Comment 3 2021-05-07 23:43:04 PDT
Created attachment 428081 [details] Patch for landing
Ross Kirsling
Comment 4 2021-05-07 23:47:00 PDT
Created attachment 428082 [details] Patch for landing
EWS
Comment 5 2021-05-08 00:23:00 PDT Comment hidden (obsolete)
EWS
Comment 6 2021-05-08 00:32:54 PDT
Committed r277224 (237495@main): <https://commits.webkit.org/237495@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428082 [details].
Radar WebKit Bug Importer
Comment 7 2021-05-08 00:33:14 PDT
<rdar://problem/77690047>
Note You need to log in before you can comment on or make changes to this bug.