Bug 225543

Summary: Web Inspector: Breakpoint action add/remove buttons are not vertically aligned with action dropdown
Product: WebKit Reporter: Patrick Angle <pangle>
Component: Web InspectorAssignee: Patrick Angle <pangle>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Screenshot of Patch v1.0
none
Patch v1.0
none
Patch v1.1 none

Patrick Angle
Reported 2021-05-07 15:33:14 PDT
.
Attachments
Screenshot of Patch v1.0 (25.09 KB, image/png)
2021-05-07 15:34 PDT, Patrick Angle 		no flags
Details
Patch v1.0 (1.51 KB, patch)
2021-05-07 15:38 PDT, Patrick Angle 		no flags
DetailsFormatted DiffDiff
Patch v1.1 (1.65 KB, patch)
2021-05-07 16:08 PDT, Patrick Angle 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-05-07 15:33:39 PDT
<rdar://problem/77675982>
Patrick Angle
Comment 2 2021-05-07 15:34:22 PDT
Created attachment 428045 [details] Screenshot of Patch v1.0
Patrick Angle
Comment 3 2021-05-07 15:38:04 PDT
Created attachment 428048 [details] Patch v1.0
Devin Rousso
Comment 4 2021-05-07 15:46:24 PDT
Comment on attachment 428048 [details] Patch v1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=428048&action=review r=me with one adjustment > Source/WebInspectorUI/UserInterface/Views/BreakpointActionView.css:32 > +.breakpoint-action-button-container { > + padding-block-start: 3px; > +} I think we should either make this `5px` and remove the `margin-top: 2px` from `:matches(.breakpoint-action-append-button, .breakpoint-action-remove-button)` or do the opposite.
Patrick Angle
Comment 5 2021-05-07 16:08:10 PDT
Created attachment 428053 [details] Patch v1.1
EWS
Comment 6 2021-05-07 17:01:39 PDT
Committed r277213 (237484@main): <https://commits.webkit.org/237484@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428053 [details].
Note You need to log in before you can comment on or make changes to this bug.