| Summary: | Web Inspector: Breakpoint action add/remove buttons are not vertically aligned with action dropdown | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Patrick Angle <pangle> | ||||||||
| Component: | Web Inspector | Assignee: | Patrick Angle <pangle> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ews-watchlist, hi, inspector-bugzilla-changes, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Patrick Angle
2021-05-07 15:33:14 PDT
Created attachment 428045 [details]
Screenshot of Patch v1.0
Created attachment 428048 [details]
Patch v1.0
Comment on attachment 428048 [details] Patch v1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=428048&action=review r=me with one adjustment > Source/WebInspectorUI/UserInterface/Views/BreakpointActionView.css:32 > +.breakpoint-action-button-container { > + padding-block-start: 3px; > +} I think we should either make this `5px` and remove the `margin-top: 2px` from `:matches(.breakpoint-action-append-button, .breakpoint-action-remove-button)` or do the opposite. Created attachment 428053 [details]
Patch v1.1
Committed r277213 (237484@main): <https://commits.webkit.org/237484@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428053 [details]. |