Bug 22552

Summary: Provide some abstraction of JIT code generation, to increase portability.
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
The patch
none
The patch, having hit 'save' on the Changelog zwarich: review+

Gavin Barraclough
Reported 2008-11-29 01:58:53 PST
Introduce a MacroAssembler layer, abstracting the architecture specific assembler. Initially, port WREC to the new abstraction.
Attachments
The patch (80.69 KB, patch)
2008-11-29 01:59 PST, Gavin Barraclough 		no flags
DetailsFormatted DiffDiff
The patch, having hit 'save' on the Changelog (77.70 KB, patch)
2008-11-29 02:00 PST, Gavin Barraclough 		zwarich: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2008-11-29 01:59:49 PST
Created attachment 25592 [details] The patch
Gavin Barraclough
Comment 2 2008-11-29 02:00:45 PST
Created attachment 25593 [details] The patch, having hit 'save' on the Changelog
Cameron Zwarich (cpst)
Comment 3 2008-11-29 02:17:42 PST
Comment on attachment 25593 [details] The patch, having hit 'save' on the Changelog This patch makes the WREC code so much cleaner. It will be a good day when we can also apply this to the JS JIT. Most of my comments are about order of declarations. In structs, we generally put constructors first and members afterwards. In classes, we generally put public: before private: and do not rely upon the implicit private: of a class definition. If you fix up the order of declarations, r=me.
Gavin Barraclough
Comment 4 2008-11-29 03:11:02 PST
Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj Adding JavaScriptCore/assembler/MacroAssembler.h Sending JavaScriptCore/assembler/X86Assembler.h Sending JavaScriptCore/interpreter/Interpreter.cpp Sending JavaScriptCore/interpreter/Interpreter.h Sending JavaScriptCore/runtime/RegExp.cpp Sending JavaScriptCore/wrec/WREC.cpp Sending JavaScriptCore/wrec/WREC.h Sending JavaScriptCore/wrec/WRECFunctors.cpp Sending JavaScriptCore/wrec/WRECFunctors.h Sending JavaScriptCore/wrec/WRECGenerator.cpp Sending JavaScriptCore/wrec/WRECGenerator.h Sending JavaScriptCore/wrec/WRECParser.cpp Sending JavaScriptCore/wrec/WRECParser.h Sending JavaScriptCore/wtf/Platform.h Transmitting file data ................ Committed revision 38839.
Note You need to log in before you can comment on or make changes to this bug.