Bug 225515

Summary: [macOS] Set the -isSourceEditable property when presenting webpage translation popup
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: PlatformAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bdakin, cdumez, ews-watchlist, gyuyoung.kim, hi, japhet, megan_gardner, ryuan.choi, sergio, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
For EWS
ews-feeder: commit-queue-
Fix CMake build
thorton: review+
Patch for landing none

Description Wenson Hsieh 2021-05-07 08:50:13 PDT 
.
Comment 1 Radar WebKit Bug Importer 2021-05-07 08:52:59 PDT 
<rdar://problem/77658040>
Comment 2 Wenson Hsieh 2021-05-07 10:26:24 PDT Comment hidden (obsolete)
Comment 3 Wenson Hsieh 2021-05-07 10:37:01 PDT 
Created attachment 428010 [details]
Fix CMake build
Comment 4 Wenson Hsieh 2021-05-07 11:23:15 PDT 
Comment on attachment 428010 [details]
Fix CMake build

View in context: https://bugs.webkit.org/attachment.cgi?id=428010&action=review

Thanks for the review!

> Source/WebCore/page/ContextMenuClient.h:38
> +#if HAVE(TRANSLATION_UI_SERVICES) && ENABLE(CONTEXT_MENUS)

(I just noticed that this ENABLE(CONTEXT_MENUS) is redundant, since this header is already wrapped in a ENABLE(CONTEXT_MENUS). I'll remove this before landing)
Comment 5 Wenson Hsieh 2021-05-07 11:56:00 PDT 
Created attachment 428017 [details]
Patch for landing
Comment 6 EWS 2021-05-07 13:28:10 PDT 
Committed r277196 (237468@main): <https://commits.webkit.org/237468@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428017 [details].