Bug 225515

Summary:

[macOS] Set the -isSourceEditable property when presenting webpage translation popup

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

Platform

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, bdakin, cdumez, ews-watchlist, gyuyoung.kim, hi, japhet, megan_gardner, ryuan.choi, sergio, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
For EWS	ews-feeder: commit-queue-
Fix CMake build	thorton: review+
Patch for landing	none

Wenson Hsieh

Reported 2021-05-07 08:50:13 PDT

Attachments
For EWS (35.74 KB, patch) 2021-05-07 10:26 PDT, Wenson Hsieh	ews-feeder: commit-queue-	Details Formatted Diff Diff
Fix CMake build (36.29 KB, patch) 2021-05-07 10:37 PDT, Wenson Hsieh	thorton: review+	Details Formatted Diff Diff
Patch for landing (36.25 KB, patch) 2021-05-07 11:56 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-05-07 08:52:59 PDT

<rdar://problem/77658040>

Wenson Hsieh

Comment 2 2021-05-07 10:26:24 PDT Comment hidden (obsolete)

Created attachment 428008 [details] For EWS

Wenson Hsieh

Comment 3 2021-05-07 10:37:01 PDT

Created attachment 428010 [details] Fix CMake build

Wenson Hsieh

Comment 4 2021-05-07 11:23:15 PDT

Comment on attachment 428010 [details] Fix CMake build View in context: https://bugs.webkit.org/attachment.cgi?id=428010&action=review Thanks for the review! > Source/WebCore/page/ContextMenuClient.h:38 > +#if HAVE(TRANSLATION_UI_SERVICES) && ENABLE(CONTEXT_MENUS) (I just noticed that this ENABLE(CONTEXT_MENUS) is redundant, since this header is already wrapped in a ENABLE(CONTEXT_MENUS). I'll remove this before landing)

Wenson Hsieh

Comment 5 2021-05-07 11:56:00 PDT

Created attachment 428017 [details] Patch for landing

EWS

Comment 6 2021-05-07 13:28:10 PDT

Committed r277196 (237468@main): <https://commits.webkit.org/237468@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428017 [details].

Note You need to log in before you can comment on or make changes to this bug.