Bug 225515 - [macOS] Set the -isSourceEditable property when presenting webpage translation popup
Summary: [macOS] Set the -isSourceEditable property when presenting webpage translatio...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
Keywords: InRadar
Depends on:
Reported: 2021-05-07 08:50 PDT by Wenson Hsieh
Modified: 2021-05-07 13:28 PDT (History)
12 users (show)

See Also:

For EWS (35.74 KB, patch)
2021-05-07 10:26 PDT, Wenson Hsieh
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Fix CMake build (36.29 KB, patch)
2021-05-07 10:37 PDT, Wenson Hsieh
thorton: review+
Details | Formatted Diff | Diff
Patch for landing (36.25 KB, patch)
2021-05-07 11:56 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-05-07 08:50:13 PDT
Comment 1 Radar WebKit Bug Importer 2021-05-07 08:52:59 PDT
Comment 2 Wenson Hsieh 2021-05-07 10:26:24 PDT Comment hidden (obsolete)
Comment 3 Wenson Hsieh 2021-05-07 10:37:01 PDT
Created attachment 428010 [details]
Fix CMake build
Comment 4 Wenson Hsieh 2021-05-07 11:23:15 PDT
Comment on attachment 428010 [details]
Fix CMake build

View in context: https://bugs.webkit.org/attachment.cgi?id=428010&action=review

Thanks for the review!

> Source/WebCore/page/ContextMenuClient.h:38

(I just noticed that this ENABLE(CONTEXT_MENUS) is redundant, since this header is already wrapped in a ENABLE(CONTEXT_MENUS). I'll remove this before landing)
Comment 5 Wenson Hsieh 2021-05-07 11:56:00 PDT
Created attachment 428017 [details]
Patch for landing
Comment 6 EWS 2021-05-07 13:28:10 PDT
Committed r277196 (237468@main): <https://commits.webkit.org/237468@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428017 [details].