| Summary: | [SOUP] Use the new libsoup network metrics API | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bugs-noreply, mcatanzaro | ||||
| Priority: | P2 | Keywords: | Gtk | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 220508 | ||||||
| Attachments: |
|
||||||
|
Description
Carlos Garcia Campos
2021-05-07 05:25:31 PDT
Created attachment 427994 [details]
Patch
Comment on attachment 427994 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427994&action=review > Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:286 > + if (!g_cancellable_is_cancelled(protectCancellable.get()) && !m_networkLoadMetrics.fetchStart) { The fact that the operation can be cancelled before returning to the main loop is strange and confusing, but you do at least have a warning comment up above, so... I guess that's OK. Comment on attachment 427994 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427994&action=review >> Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:286 >> + if (!g_cancellable_is_cancelled(protectCancellable.get()) && !m_networkLoadMetrics.fetchStart) { > > The fact that the operation can be cancelled before returning to the main loop is strange and confusing, but you do at least have a warning comment up above, so... I guess that's OK. I agree. It only happens when hsts cancels the load to start a https one. Committed r277225 (237496@main): <https://commits.webkit.org/237496@main> |