Bug 225510

Summary: [SOUP] Use the new libsoup network metrics API
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, mcatanzaro
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 220508    
Attachments:
Description Flags
Patch mcatanzaro: review+

Carlos Garcia Campos
Reported 2021-05-07 05:25:31 PDT
.
Attachments
Patch (15.31 KB, patch)
2021-05-07 05:28 PDT, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2021-05-07 05:28:35 PDT
Created attachment 427994 [details] Patch
Michael Catanzaro
Comment 2 2021-05-07 08:18:29 PDT
Comment on attachment 427994 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427994&action=review > Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:286 > + if (!g_cancellable_is_cancelled(protectCancellable.get()) && !m_networkLoadMetrics.fetchStart) { The fact that the operation can be cancelled before returning to the main loop is strange and confusing, but you do at least have a warning comment up above, so... I guess that's OK.
Carlos Garcia Campos
Comment 3 2021-05-08 03:30:34 PDT
Comment on attachment 427994 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427994&action=review >> Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:286 >> + if (!g_cancellable_is_cancelled(protectCancellable.get()) && !m_networkLoadMetrics.fetchStart) { > > The fact that the operation can be cancelled before returning to the main loop is strange and confusing, but you do at least have a warning comment up above, so... I guess that's OK. I agree. It only happens when hsts cancels the load to start a https one.
Carlos Garcia Campos
Comment 4 2021-05-08 03:43:16 PDT
Committed r277225 (237496@main): <https://commits.webkit.org/237496@main>
Note You need to log in before you can comment on or make changes to this bug.