| Summary: | Allow libwebrtc to build for Mac Catalyst | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, youennf | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Alex Christensen
2021-05-06 22:54:42 PDT
Created attachment 427973 [details]
Patch
Comment on attachment 427973 [details] Patch Nice! View in context: https://bugs.webkit.org/attachment.cgi?id=427973&action=review > Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/mac/x64/vp8_rtcd.h:658 > +#ifndef WK_MAC_CATALYST Hum, maybe I should change WEBRTC_WEBKIT_BUILD to WK_BUILD? Or maybe we should change here to WEBRTC_WEBKIT_MAC_CATALIST > Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/mac/x64/vp9_rtcd.h:518 > +#if !defined(WK_DISABLE_HARDWARE_ACCELERATION) && !defined(WK_MAC_CATALYST) And change to WEBRTC_WEBKIT_DISABLE_HARDWARE_ACCELERATION Created attachment 427999 [details]
Patch
|