Bug 225505

Summary: Allow libwebrtc to build for Mac Catalyst
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2021-05-06 22:54:42 PDT
Allow libwebrtc to build for Mac Catalyst
Attachments
Patch (21.41 KB, patch)
2021-05-06 23:00 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (27.71 KB, patch)
2021-05-07 08:36 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-05-06 23:00:19 PDT
Created attachment 427973 [details] Patch
youenn fablet
Comment 2 2021-05-07 05:27:15 PDT
Comment on attachment 427973 [details] Patch Nice! View in context: https://bugs.webkit.org/attachment.cgi?id=427973&action=review > Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/mac/x64/vp8_rtcd.h:658 > +#ifndef WK_MAC_CATALYST Hum, maybe I should change WEBRTC_WEBKIT_BUILD to WK_BUILD? Or maybe we should change here to WEBRTC_WEBKIT_MAC_CATALIST > Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/mac/x64/vp9_rtcd.h:518 > +#if !defined(WK_DISABLE_HARDWARE_ACCELERATION) && !defined(WK_MAC_CATALYST) And change to WEBRTC_WEBKIT_DISABLE_HARDWARE_ACCELERATION
Alex Christensen
Comment 3 2021-05-07 08:36:33 PDT
Created attachment 427999 [details] Patch
Alex Christensen
Comment 4 2021-05-07 09:22:02 PDT
r277176
Note You need to log in before you can comment on or make changes to this bug.