Bug 225497

Summary: Make CanvasRenderingContext always non-null in CanvasBase
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: NEW ---    
Severity: Normal CC: benjamin, cdumez, changseok, cmarcelo, darin, dino, eric.carlson, esprehn+autocc, ews-watchlist, fred.wang, glenn, graouts, gyuyoung.kim, hi, hta, jer.noble, joepeck, kangil.han, kondapallykalyan, macpherson, menard, mmaxfield, pdr, philipj, sergio, simon.fraser, tommyw, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
none
Patch ews-feeder: commit-queue-

Description Sam Weinig 2021-05-06 17:17:07 PDT
Make CanvasRenderingContext always non-null in CanvasBase
Comment 1 Sam Weinig 2021-05-06 17:23:53 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2021-05-06 17:34:38 PDT Comment hidden (obsolete)
Comment 3 Sam Weinig 2021-05-07 08:33:46 PDT Comment hidden (obsolete)
Comment 4 Sam Weinig 2021-05-07 09:05:56 PDT Comment hidden (obsolete)
Comment 5 Sam Weinig 2021-05-07 11:10:47 PDT Comment hidden (obsolete)
Comment 6 Sam Weinig 2021-05-07 13:34:21 PDT Comment hidden (obsolete)
Comment 7 Sam Weinig 2021-05-07 14:04:49 PDT Comment hidden (obsolete)
Comment 8 Sam Weinig 2021-05-07 16:39:28 PDT
Created attachment 428060 [details]
Patch
Comment 9 Dean Jackson 2021-05-07 17:06:20 PDT
Comment on attachment 428060 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428060&action=review

> Source/WTF/ChangeLog:10
> +        Add new helper to allow making UniqueRefs in a slight easier manner than always friending.

typo: slightly
Comment 10 Darin Adler 2021-05-07 17:11:03 PDT
Comment on attachment 428060 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428060&action=review

> Source/WTF/wtf/UniqueRef.h:88
> +    template<class U> friend UniqueRef<U> makeUniqueRefFromReference(U&);

This needs "adopt" in its name.
Comment 11 Sam Weinig 2021-05-07 17:35:15 PDT
(In reply to Darin Adler from comment #10)
> Comment on attachment 428060 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=428060&action=review
> 
> > Source/WTF/wtf/UniqueRef.h:88
> > +    template<class U> friend UniqueRef<U> makeUniqueRefFromReference(U&);
> 
> This needs "adopt" in its name.

WTF::makeUniqueRefAdoptingReference()?
Comment 12 Sam Weinig 2021-05-07 17:43:16 PDT
(In reply to Sam Weinig from comment #11)
> (In reply to Darin Adler from comment #10)
> > Comment on attachment 428060 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=428060&action=review
> > 
> > > Source/WTF/wtf/UniqueRef.h:88
> > > +    template<class U> friend UniqueRef<U> makeUniqueRefFromReference(U&);
> > 
> > This needs "adopt" in its name.
> 
> WTF::makeUniqueRefAdoptingReference()?

WTF::adoptReferenceMakingUniqueRef()?
Comment 13 Sam Weinig 2021-05-07 17:43:36 PDT
(In reply to Sam Weinig from comment #12)
> (In reply to Sam Weinig from comment #11)
> > (In reply to Darin Adler from comment #10)
> > > Comment on attachment 428060 [details]
> > > Patch
> > > 
> > > View in context:
> > > https://bugs.webkit.org/attachment.cgi?id=428060&action=review
> > > 
> > > > Source/WTF/wtf/UniqueRef.h:88
> > > > +    template<class U> friend UniqueRef<U> makeUniqueRefFromReference(U&);
> > > 
> > > This needs "adopt" in its name.
> > 
> > WTF::makeUniqueRefAdoptingReference()?
> 
> WTF::adoptReferenceMakingUniqueRef()?

Going to go with the latter.
Comment 14 Sam Weinig 2021-05-07 17:46:02 PDT
Created attachment 428067 [details]
Patch
Comment 15 Radar WebKit Bug Importer 2021-05-13 17:18:21 PDT
<rdar://problem/77995159>