Bug 225497

Summary: Make CanvasRenderingContext always non-null in CanvasBase
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: NEW    
Severity: Normal CC: benjamin, cdumez, changseok, cmarcelo, darin, dino, eric.carlson, esprehn+autocc, ews-watchlist, fred.wang, glenn, graouts, gyuyoung.kim, hi, hta, jer.noble, joepeck, kangil.han, kondapallykalyan, macpherson, menard, mmaxfield, pdr, philipj, sergio, simon.fraser, tommyw, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
none
Patch ews-feeder: commit-queue-

Sam Weinig
Reported 2021-05-06 17:17:07 PDT
Make CanvasRenderingContext always non-null in CanvasBase
Attachments
Patch (106.64 KB, patch)
2021-05-06 17:23 PDT, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (107.64 KB, patch)
2021-05-06 17:34 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (107.65 KB, patch)
2021-05-07 08:33 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (111.75 KB, patch)
2021-05-07 09:05 PDT, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (115.79 KB, patch)
2021-05-07 11:10 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (116.05 KB, patch)
2021-05-07 13:34 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (114.10 KB, patch)
2021-05-07 14:04 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (114.99 KB, patch)
2021-05-07 16:39 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (115.10 KB, patch)
2021-05-07 17:46 PDT, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2021-05-06 17:23:53 PDT Comment hidden (obsolete)
Sam Weinig
Comment 2 2021-05-06 17:34:38 PDT Comment hidden (obsolete)
Sam Weinig
Comment 3 2021-05-07 08:33:46 PDT Comment hidden (obsolete)
Sam Weinig
Comment 4 2021-05-07 09:05:56 PDT Comment hidden (obsolete)
Sam Weinig
Comment 5 2021-05-07 11:10:47 PDT Comment hidden (obsolete)
Sam Weinig
Comment 6 2021-05-07 13:34:21 PDT Comment hidden (obsolete)
Sam Weinig
Comment 7 2021-05-07 14:04:49 PDT Comment hidden (obsolete)
Sam Weinig
Comment 8 2021-05-07 16:39:28 PDT
Created attachment 428060 [details] Patch
Dean Jackson
Comment 9 2021-05-07 17:06:20 PDT
Comment on attachment 428060 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428060&action=review > Source/WTF/ChangeLog:10 > + Add new helper to allow making UniqueRefs in a slight easier manner than always friending. typo: slightly
Darin Adler
Comment 10 2021-05-07 17:11:03 PDT
Comment on attachment 428060 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428060&action=review > Source/WTF/wtf/UniqueRef.h:88 > + template<class U> friend UniqueRef<U> makeUniqueRefFromReference(U&); This needs "adopt" in its name.
Sam Weinig
Comment 11 2021-05-07 17:35:15 PDT
(In reply to Darin Adler from comment #10) > Comment on attachment 428060 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=428060&action=review > > > Source/WTF/wtf/UniqueRef.h:88 > > + template<class U> friend UniqueRef<U> makeUniqueRefFromReference(U&); > > This needs "adopt" in its name. WTF::makeUniqueRefAdoptingReference()?
Sam Weinig
Comment 12 2021-05-07 17:43:16 PDT
(In reply to Sam Weinig from comment #11) > (In reply to Darin Adler from comment #10) > > Comment on attachment 428060 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=428060&action=review > > > > > Source/WTF/wtf/UniqueRef.h:88 > > > + template<class U> friend UniqueRef<U> makeUniqueRefFromReference(U&); > > > > This needs "adopt" in its name. > > WTF::makeUniqueRefAdoptingReference()? WTF::adoptReferenceMakingUniqueRef()?
Sam Weinig
Comment 13 2021-05-07 17:43:36 PDT
(In reply to Sam Weinig from comment #12) > (In reply to Sam Weinig from comment #11) > > (In reply to Darin Adler from comment #10) > > > Comment on attachment 428060 [details] > > > Patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=428060&action=review > > > > > > > Source/WTF/wtf/UniqueRef.h:88 > > > > + template<class U> friend UniqueRef<U> makeUniqueRefFromReference(U&); > > > > > > This needs "adopt" in its name. > > > > WTF::makeUniqueRefAdoptingReference()? > > WTF::adoptReferenceMakingUniqueRef()? Going to go with the latter.
Sam Weinig
Comment 14 2021-05-07 17:46:02 PDT
Created attachment 428067 [details] Patch
Radar WebKit Bug Importer
Comment 15 2021-05-13 17:18:21 PDT
<rdar://problem/77995159>
Note You need to log in before you can comment on or make changes to this bug.