Summary: | Make CanvasRenderingContext always non-null in CanvasBase | ||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||||||||||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||||||||||||||
Status: | NEW --- | ||||||||||||||||||||||
Severity: | Normal | CC: | benjamin, cdumez, changseok, cmarcelo, darin, dino, eric.carlson, esprehn+autocc, ews-watchlist, fred.wang, glenn, graouts, gyuyoung.kim, hi, hta, jer.noble, joepeck, kangil.han, kondapallykalyan, macpherson, menard, mmaxfield, pdr, philipj, sergio, simon.fraser, tommyw, webkit-bug-importer | ||||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||
Attachments: |
|
Description
Sam Weinig
2021-05-06 17:17:07 PDT
Created attachment 427963 [details]
Patch
Created attachment 427964 [details]
Patch
Created attachment 427998 [details]
Patch
Created attachment 428001 [details]
Patch
Created attachment 428012 [details]
Patch
Created attachment 428027 [details]
Patch
Created attachment 428031 [details]
Patch
Created attachment 428060 [details]
Patch
Comment on attachment 428060 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428060&action=review > Source/WTF/ChangeLog:10 > + Add new helper to allow making UniqueRefs in a slight easier manner than always friending. typo: slightly Comment on attachment 428060 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428060&action=review > Source/WTF/wtf/UniqueRef.h:88 > + template<class U> friend UniqueRef<U> makeUniqueRefFromReference(U&); This needs "adopt" in its name. (In reply to Darin Adler from comment #10) > Comment on attachment 428060 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=428060&action=review > > > Source/WTF/wtf/UniqueRef.h:88 > > + template<class U> friend UniqueRef<U> makeUniqueRefFromReference(U&); > > This needs "adopt" in its name. WTF::makeUniqueRefAdoptingReference()? (In reply to Sam Weinig from comment #11) > (In reply to Darin Adler from comment #10) > > Comment on attachment 428060 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=428060&action=review > > > > > Source/WTF/wtf/UniqueRef.h:88 > > > + template<class U> friend UniqueRef<U> makeUniqueRefFromReference(U&); > > > > This needs "adopt" in its name. > > WTF::makeUniqueRefAdoptingReference()? WTF::adoptReferenceMakingUniqueRef()? (In reply to Sam Weinig from comment #12) > (In reply to Sam Weinig from comment #11) > > (In reply to Darin Adler from comment #10) > > > Comment on attachment 428060 [details] > > > Patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=428060&action=review > > > > > > > Source/WTF/wtf/UniqueRef.h:88 > > > > + template<class U> friend UniqueRef<U> makeUniqueRefFromReference(U&); > > > > > > This needs "adopt" in its name. > > > > WTF::makeUniqueRefAdoptingReference()? > > WTF::adoptReferenceMakingUniqueRef()? Going to go with the latter. Created attachment 428067 [details]
Patch
|