| Summary: | css-display-none actions from WKContentRuleList should apply to pages loaded with loadData and loadHTMLString | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, darin, ews-watchlist, japhet, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alex Christensen
2021-05-06 16:30:14 PDT
Created attachment 427952 [details]
Patch
Comment on attachment 427952 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427952&action=review > Source/WebCore/loader/DocumentLoader.cpp:528 > + // We want the CSS but not the blocking or upgrading for substitute data. Based on your change log comment I would write something more like: "We want the CSS to be loaded for us, but we ignore any attempt to block or upgrade the connection since there is no connection." Not sure my sentence was accurate, but I think it’s easier to understand than "[don’t want] the blocking or upgrading" and instead of saying "for substitute data" which is already said by the name of the function we are in, we can point out *why* we ignore attempts to block or upgrade. |