Bug 225480

Summary: Sampled Page Top Color: move logic out of `Document`
Product: WebKit Reporter: Devin Rousso <hi>
Component: New BugsAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bdakin, cdumez, darin, esprehn+autocc, ews-watchlist, gyuyoung.kim, hi, kangil.han, ryuan.choi, sam, sergio, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Devin Rousso
Reported 2021-05-06 13:41:33 PDT
.
Attachments
Patch (25.72 KB, patch)
2021-05-06 13:42 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (26.43 KB, patch)
2021-05-06 15:33 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (37.85 KB, patch)
2021-05-13 18:25 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (37.83 KB, patch)
2021-05-14 16:40 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2021-05-06 13:42:46 PDT
Created attachment 427931 [details] Patch
Devin Rousso
Comment 2 2021-05-06 15:33:14 PDT
Created attachment 427944 [details] Patch
Sam Weinig
Comment 3 2021-05-07 09:17:37 PDT
Comment on attachment 427944 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427944&action=review > Source/WebCore/ChangeLog:4 > + Sampled Page Top Color: move logic out of `Document` > + https://bugs.webkit.org/show_bug.cgi?id=225480 If you are moving it out of Document, might I suggest moving it to its own struct/class? It seems like an object Page could own.
Darin Adler
Comment 4 2021-05-08 22:01:54 PDT
Comment on attachment 427944 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427944&action=review >> Source/WebCore/ChangeLog:4 >> + https://bugs.webkit.org/show_bug.cgi?id=225480 > > If you are moving it out of Document, might I suggest moving it to its own struct/class? It seems like an object Page could own. I agree that this is a good suggestion.
Radar WebKit Bug Importer
Comment 5 2021-05-13 13:42:15 PDT
<rdar://problem/77984539>
Devin Rousso
Comment 6 2021-05-13 18:25:02 PDT
Created attachment 428591 [details] Patch
EWS
Comment 7 2021-05-14 15:30:55 PDT
Tools/Scripts/svn-apply failed to apply attachment 428591 [details] to trunk. Please resolve the conflicts and upload a new patch.
Devin Rousso
Comment 8 2021-05-14 16:40:48 PDT
Created attachment 428683 [details] Patch
EWS
Comment 9 2021-05-14 17:29:27 PDT
Committed r277523 (237751@main): <https://commits.webkit.org/237751@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428683 [details].
Note You need to log in before you can comment on or make changes to this bug.