| Summary: | Sampled Page Top Color: move logic out of `Document` | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||||
| Component: | New Bugs | Assignee: | Devin Rousso <hi> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | annulen, bdakin, cdumez, darin, esprehn+autocc, ews-watchlist, gyuyoung.kim, hi, kangil.han, ryuan.choi, sam, sergio, thorton, webkit-bug-importer, wenson_hsieh | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Devin Rousso
2021-05-06 13:41:33 PDT
Created attachment 427931 [details]
Patch
Created attachment 427944 [details]
Patch
Comment on attachment 427944 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427944&action=review > Source/WebCore/ChangeLog:4 > + Sampled Page Top Color: move logic out of `Document` > + https://bugs.webkit.org/show_bug.cgi?id=225480 If you are moving it out of Document, might I suggest moving it to its own struct/class? It seems like an object Page could own. Comment on attachment 427944 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427944&action=review >> Source/WebCore/ChangeLog:4 >> + https://bugs.webkit.org/show_bug.cgi?id=225480 > > If you are moving it out of Document, might I suggest moving it to its own struct/class? It seems like an object Page could own. I agree that this is a good suggestion. Created attachment 428591 [details]
Patch
Tools/Scripts/svn-apply failed to apply attachment 428591 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Created attachment 428683 [details]
Patch
Committed r277523 (237751@main): <https://commits.webkit.org/237751@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428683 [details]. |