Bug 225477

Summary: Add ObjC API similar to WKBundlePageCopyGroupIdentifier
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch cdumez: review+

Alex Christensen
Reported 2021-05-06 12:53:21 PDT
Add ObjC API similar to WKBundlePageCopyGroupIdentifier
Attachments
Patch (10.23 KB, patch)
2021-05-06 12:55 PDT, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (10.14 KB, patch)
2021-05-06 13:26 PDT, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (10.45 KB, patch)
2021-05-06 13:58 PDT, Alex Christensen 		cdumez: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-05-06 12:55:13 PDT
Created attachment 427924 [details] Patch
Alex Christensen
Comment 2 2021-05-06 13:26:52 PDT
Created attachment 427928 [details] Patch
Alex Christensen
Comment 3 2021-05-06 13:58:55 PDT
Created attachment 427934 [details] Patch
Darin Adler
Comment 4 2021-05-08 22:03:12 PDT
Comment on attachment 427934 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427934&action=review > Source/WebKit/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h:50 > +@property (nonatomic, readonly) NSString *_groupIdentifier WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); Bug title says API, but this has an underscore and is private. Should this be API?
Alex Christensen
Comment 5 2021-05-10 09:04:55 PDT
All of our injected bundle API is private. This should be private.
Alex Christensen
Comment 6 2021-05-10 10:11:31 PDT
Comment on attachment 427934 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427934&action=review > Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInPageGroup.h:30 > +WK_CLASS_DEPRECATED_WITH_REPLACEMENT("WKWebProcessPlugInBrowserContextController._groupIdentifier", macos(10.10, WK_MAC_TBA), ios(8.0, WK_IOS_TBA)) Internal commit 94dff8a788b4d924ccfabf211f3daf39dbd63d12 to ignore this deprecation for staging.
Alex Christensen
Comment 7 2021-05-10 11:59:10 PDT
http://trac.webkit.org/r277280
Radar WebKit Bug Importer
Comment 8 2021-05-10 12:00:22 PDT
<rdar://problem/77773734>
Note You need to log in before you can comment on or make changes to this bug.