| Summary: | Add ObjC API similar to WKBundlePageCopyGroupIdentifier | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cdumez, darin, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Alex Christensen
2021-05-06 12:53:21 PDT
Created attachment 427924 [details]
Patch
Created attachment 427928 [details]
Patch
Created attachment 427934 [details]
Patch
Comment on attachment 427934 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427934&action=review > Source/WebKit/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h:50 > +@property (nonatomic, readonly) NSString *_groupIdentifier WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); Bug title says API, but this has an underscore and is private. Should this be API? All of our injected bundle API is private. This should be private. Comment on attachment 427934 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427934&action=review > Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInPageGroup.h:30 > +WK_CLASS_DEPRECATED_WITH_REPLACEMENT("WKWebProcessPlugInBrowserContextController._groupIdentifier", macos(10.10, WK_MAC_TBA), ios(8.0, WK_IOS_TBA)) Internal commit 94dff8a788b4d924ccfabf211f3daf39dbd63d12 to ignore this deprecation for staging. |